I don't scare that easily. :-)
On Thu, Nov 26, 2015 at 12:39 PM, compn wrote:
> On Wed, 25 Nov 2015 11:21:55 -0800
> Bruce Dawson wrote:
> > I'm mentioning this just in case some other lost soul shows up trying
> > to contribute a patch to a Chromium only file. I'll get my patch
> > landed in
On Wed, 25 Nov 2015 11:21:55 -0800
Bruce Dawson wrote:
> I'm mentioning this just in case some other lost soul shows up trying
> to contribute a patch to a Chromium only file. I'll get my patch
> landed in the right place.
>
> Thanks for the help.
hope we did not scare you off.
-compn
_
I tracked down the source of the confusion. The Chromium team has a repo
that sits between Chromium and the main ffmpeg repo. This repo is discussed
here:
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git
The trouble is that this page shows README instead of README.chromium, so
it
On 11/25/2015 12:05 AM, Bruce Dawson wrote:
> This would make ffmpeg fail on VS versions prior to VS 2013, for those
> using the BUILD.gn file, which I assume is not many. It would be easy to
> add additional conditionals for earlier versions, but if it's just for
> Chromium then 2013/2015 is suffi
On Wed, Nov 25, 2015 at 1:38 AM, Bruce Dawson wrote:
> Yes - the modifications to BUILD.gn seem to all be done by Google/Chromium
> engineers.
>
> When Chromium pulls in a third party dependency they sometimes but the
> build files just outside of the copy of the third party repo, and this time
>
Yes - the modifications to BUILD.gn seem to all be done by Google/Chromium
engineers.
When Chromium pulls in a third party dependency they sometimes but the
build files just outside of the copy of the third party repo, and this time
the build files got checked in to the upstream repo. I'm not sure
On Tue, 24 Nov 2015 16:02:01 -0800
Bruce Dawson wrote:
> Interesting. I grabbed the code with:
>
> git clone https://chromium.googlesource.com/chromium/third_party/ffmpeg
>
> and that contains BUILD.gn as part of the repo. Is it possible that
> BUILD.gn is part of the repo but is only used when
This would make ffmpeg fail on VS versions prior to VS 2013, for those
using the BUILD.gn file, which I assume is not many. It would be easy to
add additional conditionals for earlier versions, but if it's just for
Chromium then 2013/2015 is sufficient.
VS versions after 2015 will work automatical
On Tue, 24 Nov 2015 14:18:47 -0800
Bruce Dawson wrote:
> The attached patch lets ffmpeg build with both VS 2013 and VS 2015.
>
> Comments?
>
not sure if ffmpeg is supporting VS 2010, but does this work on VS2010
(or any other VS besides 2013/2015) after your changes?
thanks
-compn
___
Interesting. I grabbed the code with:
git clone https://chromium.googlesource.com/chromium/third_party/ffmpeg
and that contains BUILD.gn as part of the repo. Is it possible that
BUILD.gn is part of the repo but is only used when it is part of Chromium?
That appears to be the case, in which case C
On Tue, Nov 24, 2015 at 11:18 PM, Bruce Dawson wrote:
> I've been working on getting Chromium compiling with VS 2015 and there are
> some tweaks needed to ffmpeg to get it working with gn. Currently the
> BUILD.gn file defines five symbols/keywords that are missing from VS 2013's
> C compiler, and
11 matches
Mail list logo
