On Tuesday, 19 October 2021 3:29:20 AM AEDT Paul B Mahol wrote:
> On Mon, Oct 18, 2021 at 6:58 AM Brad Hards wrote:
> > The patch isn't very invasive, and is closely based on previous nv and
> > x265 patches.
>
> You mean the one LGTMed by Derek?
Derek previously LGTM'd the x265 one, and has now
On Mon, Oct 18, 2021 at 6:58 AM Brad Hards wrote:
> If possible, I'd like a review on
>
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210806091633.2083-1-br...@frogmouth.net/[1]
>
> Its been a couple of months, and I haven't got any feedback.
>
> The patch isn't very invasive, and is clos
On Sunday, 11 July 2021 10:01:47 PM AEST Derek Buitenhuis wrote:
> Can you amend the commit message to contain the reasoning from [1]?
Amended.
> A quick review:
> > +void *sei_data;
> > +int sei_data_size;
>
> I don't see sei_data freed anywhere at the end of decoding?
Fixed in v2. Inclu
On 11.07.2021 14:01, Derek Buitenhuis wrote:
Hi Brad,
On 7/8/2021 4:31 AM, Brad Hards wrote:
About a month ago, I submitted a patch to add User Data Unregistered SEI
writing to the x265 implementation.
See http://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/280978.html[1]
and
https://patchwork.
Hi Brad,
On 7/8/2021 4:31 AM, Brad Hards wrote:
> About a month ago, I submitted a patch to add User Data Unregistered SEI
> writing to the x265 implementation.
>
> See http://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/280978.html[1]
> and
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/202
