Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-28 Thread Dale Curtis
On Mon, Feb 26, 2018 at 3:07 PM, Michael Niedermayer wrote: > > The way parsers are intended to work (that is years ago and i dont remember > that there was a proposal to change this) > is to never drop data. Thats how the stuff was intended to work. > > On top of that it was sometimes convenient

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-26 Thread Michael Niedermayer
On Mon, Feb 26, 2018 at 10:30:26AM -0800, Dale Curtis wrote: > On Fri, Feb 23, 2018 at 7:01 PM, Michael Niedermayer > wrote: > > > > this goes the wrong direction. > > Parsers should not discard data by default. The code we have for tags is a > > hack. > > There are many better ways to handle this

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-26 Thread wm4
On Mon, 26 Feb 2018 10:30:26 -0800 Dale Curtis wrote: > On Fri, Feb 23, 2018 at 7:01 PM, Michael Niedermayer > wrote: > > > > this goes the wrong direction. > > Parsers should not discard data by default. The code we have for tags is a > > hack. > > There are many better ways to handle this. > >

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-26 Thread Dale Curtis
On Fri, Feb 23, 2018 at 7:01 PM, Michael Niedermayer wrote: > > this goes the wrong direction. > Parsers should not discard data by default. The code we have for tags is a > hack. > There are many better ways to handle this. > Something similar to a AV_PKT_FLAG_CORRUPT set be the parser would be a

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-23 Thread Michael Niedermayer
On Fri, Feb 23, 2018 at 11:15:09AM -0800, Dale Curtis wrote: > Whoops, that version spams on every flush; changed to only print when > buf_size > 0. > > - dale > > On Fri, Feb 23, 2018 at 10:37 AM, Dale Curtis > wrote: > > > After some deeper testing it looks like this mechanism can actually fu

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-23 Thread Dale Curtis
Whoops, that version spams on every flush; changed to only print when buf_size > 0. - dale On Fri, Feb 23, 2018 at 10:37 AM, Dale Curtis wrote: > After some deeper testing it looks like this mechanism can actually fully > replace the existing ID3 and APE tag skips; so I've simplified the patch

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-23 Thread Dale Curtis
After some deeper testing it looks like this mechanism can actually fully replace the existing ID3 and APE tag skips; so I've simplified the patch to do so. - dale On Thu, Feb 22, 2018 at 4:46 PM, Dale Curtis wrote: > The parser should only return valid mpeg audio packets; it generally > does s