Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-16 Thread Tomas Härdin
On 2017-08-15 21:15, Moritz Barsnick wrote: On Tue, Aug 08, 2017 at 23:49:45 +0200, Tomas Härdin wrote: Feel free to comment Don't forget to mention #1959 in the commit message. Huh, I didn't know there was a ticket for it. That audiobook guy popped up on [Freetel-codec2] too, and thus the c

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-15 Thread Moritz Barsnick
On Tue, Aug 08, 2017 at 23:49:45 +0200, Tomas Härdin wrote: > Feel free to comment Don't forget to mention #1959 in the commit message. Hilsen, Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-10 Thread Tomas
Michael Niedermayer skrev > On Tue, Aug 08, 2017 at 11:49:45PM +0200, Tomas Härdin wrote: > [...] > > > ffmpeg.c |3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > 5bd20883fdc12aefa609fc803fe5709069b3e9a0 > > 0003-Don-t-complain-about-codec2-s-700-bit-s-modes-in-ffm.

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-10 Thread Paul B Mahol
On 8/9/17, Michael Niedermayer wrote: > On Tue, Aug 08, 2017 at 11:49:45PM +0200, Tomas Härdin wrote: > [...] > >> ffmpeg.c |3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> 5bd20883fdc12aefa609fc803fe5709069b3e9a0 >> 0003-Don-t-complain-about-codec2-s-700-bit-s-modes-in-ffm.patch

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-09 Thread Michael Niedermayer
On Tue, Aug 08, 2017 at 11:49:45PM +0200, Tomas Härdin wrote: [...] > ffmpeg.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > 5bd20883fdc12aefa609fc803fe5709069b3e9a0 > 0003-Don-t-complain-about-codec2-s-700-bit-s-modes-in-ffm.patch > From b693b6175289e6ad0c643462d8f69f68300860

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-08 Thread Tomas Härdin
On Fri, 2017-08-04 at 19:20 +0200, Tomas Härdin wrote: > TODO: > > * have -mode be an integer and use the CONST system Nicolas mentioned > * option for demuxing multiple frames at a time > * sort the extradata aliasing thing > * address API issues in libcodec2, possibly modify the format (there >

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-04 Thread Tomas Härdin
On Thu, 2017-08-03 at 22:24 +0200, Reimar Döffinger wrote: > On Thu, Aug 03, 2017 at 12:40:04AM +0200, Tomas Härdin wrote: > > > > > +//statically assert the size of avpriv_codec2_header > > +//putting it here because all codec2 things depend on > > codec2utils > > +switch(0) { > > + 

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Reimar Döffinger
On Thu, Aug 03, 2017 at 12:40:04AM +0200, Tomas Härdin wrote: > +//statically assert the size of avpriv_codec2_header > +//putting it here because all codec2 things depend on codec2utils > +switch(0) { > +case 0: > +case sizeof(avpriv_codec2_header) == 7: //if false then the co

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Hendrik Leppkes
On Thu, Aug 3, 2017 at 5:45 PM, Tomas Härdin wrote: >> > +} else { >> > +if (avctx->extradata_size != sizeof(avpriv_codec2_header)) >> > { >> > +av_log(avctx, AV_LOG_ERROR, "must have exactly %zu >> > bytes of extradata (got %i)\n", >> > + sizeof(avpriv_co

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Tomas Härdin
On Thu, 2017-08-03 at 13:00 +0200, Nicolas George wrote: > Le sextidi 16 thermidor, an CCXXV, Tomas Härdin a écrit : > > With both the raw demuxer and the encoder you need to specify the > > desired mode, like this: > The encoder could default to one the two. Default on-the-air is 1300 (aka FreeDV

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Nicolas George
Le sextidi 16 thermidor, an CCXXV, Tomas Härdin a écrit : > Posting this to both [ffmpeg-devel] and [Freetel-codec2] in hopes of > maximum feedback. > > I've been spending the last few days getting codec2 (http://freedv.org/ > ) hooked up in libavcodec, and a set of muxers and demuxers for both >

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Tomas Härdin
On Thu, 2017-08-03 at 01:07 +0200, Carl Eugen Hoyos wrote: > 2017-08-03 0:40 GMT+02:00 Tomas Härdin : > > > > > Decoding a .c2 file is straightforward however, thanks to the > > header: > > > >   ffmpeg -i report2074.c2 out.wav > The probe score is too high. > I suspect you should also check for

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-02 Thread Carl Eugen Hoyos
2017-08-03 0:40 GMT+02:00 Tomas Härdin : > Decoding a .c2 file is straightforward however, thanks to the header: > > ffmpeg -i report2074.c2 out.wav The probe score is too high. I suspect you should also check for the major version, the score should be MAX/2 if the first 32bit are ok, significa