Re: [FFmpeg-devel] [RFC PATCH v2] avutil/frame: fix remove_side_data

2019-11-11 Thread Marton Balint
On Sun, 10 Nov 2019, Marton Balint wrote: On Sun, 3 Nov 2019, Zhao Zhili wrote: remove_side_data is supposed to remove a single instance by design. Since new_side_data() doesn't forbid add multiple instances of the same type, remove_side_data should deal with that. --- I'm afraid this patc

Re: [FFmpeg-devel] [RFC PATCH v2] avutil/frame: fix remove_side_data

2019-11-10 Thread Marton Balint
On Sun, 3 Nov 2019, Zhao Zhili wrote: remove_side_data is supposed to remove a single instance by design. Since new_side_data() doesn't forbid add multiple instances of the same type, remove_side_data should deal with that. --- I'm afraid this patch makes it harder to enforce single entry per