Re: [FFmpeg-devel] [PATCHv2] avcodec: ViewQuest VQC decoder

2022-10-18 Thread Peter Ross
On Tue, Oct 18, 2022 at 12:05:05PM +0200, Tomas Härdin wrote: > sön 2022-10-09 klockan 11:36 +1100 skrev Peter Ross: > > > > +    gamma = buf[0] >> 4; > > +    contrast = AV_RL16(buf + 2) >> 1; > > +    if (gamma || contrast) > > +    avpriv_request_sample(avctx, "gamma=0x%x, contrast=0x%x\n",

Re: [FFmpeg-devel] [PATCHv2] avcodec: ViewQuest VQC decoder

2022-10-18 Thread Tomas Härdin
sön 2022-10-09 klockan 11:36 +1100 skrev Peter Ross: > > +    gamma = buf[0] >> 4; > +    contrast = AV_RL16(buf + 2) >> 1; > +    if (gamma || contrast) > +    avpriv_request_sample(avctx, "gamma=0x%x, contrast=0x%x\n", > gamma, contrast); Shouldn't this also error out with AVERROR_PATCHWELC

Re: [FFmpeg-devel] [PATCHv2] avcodec: ViewQuest VQC decoder

2022-10-16 Thread Peter Ross
On Sun, Oct 09, 2022 at 11:36:09AM +1100, Peter Ross wrote: > Reviewed-by: Andreas Rheinhardt > Reviewed-by: Tomas Härdin > --- > > Thanks for reviews. All suggestions implemented. > > Changelog | 1 + > doc/general_contents.texi | 1 + > libavcodec/Makefile | 1 + >