Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-29 Thread Ronald S. Bultje
Hi, On Thu, Oct 29, 2015 at 7:55 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 29, 2015 at 12:29 AM, Michael Niedermayer > wrote: > > On Wed, Oct 28, 2015 at 07:02:42PM -0400, Ganesh Ajjanagadde wrote: > >> On Wed, Oct 28, 2015 at 3:05 PM, Ronald S. Bultje > wrote: > >> > Hi, > >> > > >> > On We

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 12:29 AM, Michael Niedermayer wrote: > On Wed, Oct 28, 2015 at 07:02:42PM -0400, Ganesh Ajjanagadde wrote: >> On Wed, Oct 28, 2015 at 3:05 PM, Ronald S. Bultje wrote: >> > Hi, >> > >> > On Wed, Oct 28, 2015 at 2:46 PM, Ganesh Ajjanagadde >> > >> > wrote: >> >> >> >> On W

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Michael Niedermayer
On Wed, Oct 28, 2015 at 07:02:42PM -0400, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 3:05 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 2:46 PM, Ganesh Ajjanagadde > > wrote: > >> > >> On Wed, Oct 28, 2015 at 2:39 PM, Ronald S. Bultje > >> wrote: > >> > Hi, > >> >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 3:05 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 2:46 PM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 2:39 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde >> > >> > wrote: >> >> >> >> O

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 2:46 PM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 2:39 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 2:39 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28, 2015 at 11:00 AM, Ganesh Ajjanagadde >> > wrote: >> >> >> >> On W

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 2:31 PM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 11:00 AM, Ganesh Ajjanagadde > > wrote: > >> > >> On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje > >> wrote: > >> > Hi, > >>

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 11:33 AM, Hendrik Leppkes wrote: > On Wed, Oct 28, 2015 at 4:00 PM, Ganesh Ajjanagadde > wrote: >> On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje >> wrote: >>> Hi, >>> >>> On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde >>> wrote: On Wed, Oct 28, 2015

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 11:44 AM, Clément Bœsch wrote: > On Wed, Oct 28, 2015 at 10:34:37AM -0400, Ronald S. Bultje wrote: > [...] >> You could do the same for the last 4 values of the cinething changes, they >> are clearly not enums, but flags. Flags are always unsigned, so if enums >> are unsign

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 11:38 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 11:00 AM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde >> > wrote: >> >> >> >> On

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Clément Bœsch
On Wed, Oct 28, 2015 at 10:34:37AM -0400, Ronald S. Bultje wrote: [...] > You could do the same for the last 4 values of the cinething changes, they > are clearly not enums, but flags. Flags are always unsigned, so if enums > are unsigned and that causes an issue (as it does here), it makes sense t

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 11:00 AM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde > > wrote: > >> > >> On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje > >> wrote: > >> > Hi, > >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Hendrik Leppkes
On Wed, Oct 28, 2015 at 4:00 PM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje wrote: >> Hi, >> >> On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde >> wrote: >>> >>> On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje >>> wrote: >>> > Hi, >>> > >>> > On Wed,

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 10:53 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Oct 28, 2015 at 8:20 AM, Ganesh Ajjanagadde >> > >> > wrote: >> >> >> >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 10:48 AM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Oct 28, 2015 at 8:20 AM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> On Wed, Oct 28, 2015 at 7:00 AM, Ronald S. Bultje >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 10:34 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 28, 2015 at 8:20 AM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Oct 28, 2015 at 7:00 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, Oct 27, 2015 at 10:58 PM, Ganesh Ajjanagadde >> > wrote: >> >> >> >> On T

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Wed, Oct 28, 2015 at 8:20 AM, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 7:00 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, Oct 27, 2015 at 10:58 PM, Ganesh Ajjanagadde > > wrote: > >> > >> On Tue, Oct 27, 2015 at 10:41 PM, Ronald S. Bultje > >> wrote: > >> > Hi, > >>

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 7:00 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Oct 27, 2015 at 10:58 PM, Ganesh Ajjanagadde > wrote: >> >> On Tue, Oct 27, 2015 at 10:41 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, Oct 27, 2015 at 8:53 PM, Ganesh Ajjanagadde >> > >> > wrote: >> >> >> >>

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread Ronald S. Bultje
Hi, On Tue, Oct 27, 2015 at 10:58 PM, Ganesh Ajjanagadde wrote: > On Tue, Oct 27, 2015 at 10:41 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, Oct 27, 2015 at 8:53 PM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> ISO C restricts enumerator values to the range of in

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-28 Thread wm4
On Tue, 27 Oct 2015 20:53:39 -0400 Ganesh Ajjanagadde wrote: > ISO C restricts enumerator values to the range of int. Thus (for instance) > 0x8000 > unfortunately does not work, and throws a warning with -Wpedantic on > clang 3.7. > > This fixes it by using alternative expressions that resu

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-27 Thread Ganesh Ajjanagadde
On Tue, Oct 27, 2015 at 10:41 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, Oct 27, 2015 at 8:53 PM, Ganesh Ajjanagadde > wrote: >> >> ISO C restricts enumerator values to the range of int. Thus (for instance) >> 0x8000 >> unfortunately does not work, and throws a warning with -Wpedantic on >

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-27 Thread Ronald S. Bultje
Hi, On Tue, Oct 27, 2015 at 8:53 PM, Ganesh Ajjanagadde wrote: > ISO C restricts enumerator values to the range of int. Thus (for instance) > 0x8000 > unfortunately does not work, and throws a warning with -Wpedantic on > clang 3.7. > > This fixes it by using alternative expressions that res

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

2015-10-27 Thread Michael Niedermayer
On Tue, Oct 27, 2015 at 08:53:39PM -0400, Ganesh Ajjanagadde wrote: > ISO C restricts enumerator values to the range of int. Thus (for instance) > 0x8000 > unfortunately does not work, and throws a warning with -Wpedantic on > clang 3.7. > > This fixes it by using alternative expressions that