Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-10-01 Thread Michael Niedermayer
On Wed, Oct 01, 2014 at 05:32:52PM +0200, wm4 wrote: > On Wed, 1 Oct 2014 17:11:17 +0200 > Michael Niedermayer wrote: > > > > Ouch. Yeah, I think this function used to corrupt perfectly fine h264 > > > mpegts timestamps in the past or so... > > > > which trac ticket is that ? > > or do you mean

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-10-01 Thread wm4
On Wed, 1 Oct 2014 17:11:17 +0200 Michael Niedermayer wrote: > > Ouch. Yeah, I think this function used to corrupt perfectly fine h264 > > mpegts timestamps in the past or so... > > which trac ticket is that ? > or do you mean by "past" that this is not relevant anymore as it has > been fixed al

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-10-01 Thread Michael Niedermayer
On Wed, Oct 01, 2014 at 03:07:19PM +0200, wm4 wrote: > On Wed, 1 Oct 2014 12:58:32 +0200 > Michael Niedermayer wrote: > > > On Wed, Oct 01, 2014 at 01:36:58PM +0300, Petri Hintukainen wrote: > > > On ti, 2014-09-30 at 16:09 +0200, wm4 wrote: > > > > On Tue, 30 Sep 2014 12:01:33 +0300 > > > > Petr

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-10-01 Thread wm4
On Wed, 1 Oct 2014 12:58:32 +0200 Michael Niedermayer wrote: > On Wed, Oct 01, 2014 at 01:36:58PM +0300, Petri Hintukainen wrote: > > On ti, 2014-09-30 at 16:09 +0200, wm4 wrote: > > > On Tue, 30 Sep 2014 12:01:33 +0300 > > > Petri Hintukainen wrote: > > > > > > > Hello, > > > > > > > > Missin

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-10-01 Thread Michael Niedermayer
On Wed, Oct 01, 2014 at 01:36:58PM +0300, Petri Hintukainen wrote: > On ti, 2014-09-30 at 16:09 +0200, wm4 wrote: > > On Tue, 30 Sep 2014 12:01:33 +0300 > > Petri Hintukainen wrote: > > > > > Hello, > > > > > > Missing DTS combined with non-monotonic PTS seems to cause some > > > problems. This

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-10-01 Thread Petri Hintukainen
On ti, 2014-09-30 at 16:09 +0200, wm4 wrote: > On Tue, 30 Sep 2014 12:01:33 +0300 > Petri Hintukainen wrote: > > > Hello, > > > > Missing DTS combined with non-monotonic PTS seems to cause some > > problems. This is with the file from ticket #2208 (I added dumping > > timestamps to demuxer and m

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-30 Thread wm4
On Tue, 30 Sep 2014 12:01:33 +0300 Petri Hintukainen wrote: > Hello, > > Missing DTS combined with non-monotonic PTS seems to cause some > problems. This is with the file from ticket #2208 (I added dumping > timestamps to demuxer and muxer): > > > $ ../ffmpeg -i orig/track_06\ -\ Subtitle.sup

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-30 Thread Petri Hintukainen
Hello, Missing DTS combined with non-monotonic PTS seems to cause some problems. This is with the file from ticket #2208 (I added dumping timestamps to demuxer and muxer): $ ../ffmpeg -i orig/track_06\ -\ Subtitle.sup -scodec copy 6.sup ffmpeg version N-66546-gea74007 Copyright (c) 2000-2014 the

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-26 Thread Clément Bœsch
On Fri, Sep 26, 2014 at 01:32:09PM +0300, Petri Hintukainen wrote: > On pe, 2014-09-26 at 12:26 +0200, Clément Bœsch wrote: > > On Fri, Sep 26, 2014 at 10:13:34AM +, Carl Eugen Hoyos wrote: > > > Clément Bœsch pkh.me> writes: > > > > > > > Thank you for the patch. Looking forward the muxer, a

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-26 Thread Petri Hintukainen
On pe, 2014-09-26 at 12:26 +0200, Clément Bœsch wrote: > On Fri, Sep 26, 2014 at 10:13:34AM +, Carl Eugen Hoyos wrote: > > Clément Bœsch pkh.me> writes: > > > > > Thank you for the patch. Looking forward the muxer, and a FATE test. > > > > Is there a reason why you didn't merge the muxer? >

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-26 Thread Carl Eugen Hoyos
Clément Bœsch pkh.me> writes: > > Is there a reason why you didn't merge the muxer? > > http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/182167 > > > > I didn't look at it really but I thought it was > still waiting for a few changes. None were requested... Carl Eugen _

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-26 Thread Clément Bœsch
On Fri, Sep 26, 2014 at 10:13:34AM +, Carl Eugen Hoyos wrote: > Clément Bœsch pkh.me> writes: > > > Thank you for the patch. Looking forward the muxer, and a FATE test. > > Is there a reason why you didn't merge the muxer? > http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/182167 > I

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-26 Thread Carl Eugen Hoyos
Clément Bœsch pkh.me> writes: > Thank you for the patch. Looking forward the muxer, and a FATE test. Is there a reason why you didn't merge the muxer? http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/182167 Thank you for the commit, Carl Eugen _

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-26 Thread Clément Bœsch
On Wed, Sep 24, 2014 at 05:38:58PM +0200, wm4 wrote: > --- > doc reference, bump minor, no other changes > --- > doc/general.texi | 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/supdec.c | 109 > +++

Re: [FFmpeg-devel] [PATCH v7] Add SUP/PGS subtitle demuxer

2014-09-24 Thread compn
On Wed, 24 Sep 2014 17:38:58 +0200 wm4 wrote: > --- a/doc/general.texi > +++ b/doc/general.texi > @@ -453,6 +453,7 @@ library: > @item Sony PlayStation STR @tab @tab X > @item Sony Wave64 (W64) @tab X @tab X > @item SoX native format @tab X @tab X > +@item SUP raw PGS su