Re: [FFmpeg-devel] [PATCH v6 1/1] avformat: Add IPFS protocol support.

2022-02-16 Thread Mark Gaiser
On Wed, Feb 16, 2022 at 10:40 AM Tomas Härdin wrote: > > > +// Test $IPFS_GATEWAY. > > +if (getenv("IPFS_GATEWAY") != NULL) { > > +snprintf(c->gateway_buffer, sizeof(c->gateway_buffer), "%s", > > + getenv("IPFS_GATEWAY")); > > might want to error check this one > >

Re: [FFmpeg-devel] [PATCH v6 1/1] avformat: Add IPFS protocol support.

2022-02-16 Thread Tomas Härdin
> +    // Test $IPFS_GATEWAY. > +    if (getenv("IPFS_GATEWAY") != NULL) { > +    snprintf(c->gateway_buffer, sizeof(c->gateway_buffer), "%s", > + getenv("IPFS_GATEWAY")); might want to error check this one > +    ret = 1; > +    goto err; > +    } else > +    av_