Re: [FFmpeg-devel] [PATCH v5] avcodec/mfenc: Dynamically load MFPlat.DLL

2022-05-24 Thread Trystan Mata
Firstly, thank you for your review. > You shouldn't use win32_dlopen directly (there's no preexisting code that > does that). If you want to use the helpers from w32dlfcn.h, call dlopen > and dlclose, which then redirect to those functions. But here I don't see > any need to use that wrapper w

Re: [FFmpeg-devel] [PATCH v5] avcodec/mfenc: Dynamically load MFPlat.DLL

2022-05-24 Thread Martin Storsjö
On Sat, 21 May 2022, Trystan Mata wrote: Changes since the v4: - Avoid having two mf_init function declared (missing #if !HAVE_UWP) - Better commit message about linking with UWP Changes since the v3: - Library handle and function pointer are no longer in MFContext. - If UWP is enabled, avcod