Re: [FFmpeg-devel] [PATCH v5] Mark C globals with small code model

2025-06-23 Thread Pranav Kant via ffmpeg-devel
--- Begin Message --- Apologies for the late reply. Yeah, the other solution to solve this problem is to sprinkle .gotpcrel all over the x86 assembly whenever it tries to access a variable that's defined in the C file. Using `attribute(small)`, as in this patch, is behind a macro that implies tha

Re: [FFmpeg-devel] [PATCH v5] Mark C globals with small code model

2025-05-07 Thread Rémi Denis-Courmont
Hi, This looks like a kludge to me. If static variables are too far away, then the assembler code that refers to them needs to be fixed, and that's all that there is to it. You can't just magically make the data and the code closer, especially if FFmpeg is compiled as a static library (a very

Re: [FFmpeg-devel] [PATCH v5] Mark C globals with small code model

2025-04-28 Thread Pranav Kant via ffmpeg-devel
Ping. On Tue, Apr 15, 2025 at 4:22 PM Pranav Kant wrote: > Hello again. Is there anything else I can do here? > > On Fri, Apr 4, 2025 at 11:40 AM Pranav Kant wrote: > >> Any thoughts on this? >> >> On Thu, Mar 20, 2025 at 5:30 PM Pranav Kant wrote: >> >>> Patch version v5: >>> - Uses two new m

Re: [FFmpeg-devel] [PATCH v5] Mark C globals with small code model

2025-04-15 Thread Pranav Kant via ffmpeg-devel
Hello again. Is there anything else I can do here? On Fri, Apr 4, 2025 at 11:40 AM Pranav Kant wrote: > Any thoughts on this? > > On Thu, Mar 20, 2025 at 5:30 PM Pranav Kant wrote: > >> Patch version v5: >> - Uses two new macros DECLARE_ASM_VAR (used for both external and inline >> asm) and DEC

Re: [FFmpeg-devel] [PATCH v5] Mark C globals with small code model

2025-04-04 Thread Pranav Kant via ffmpeg-devel
Any thoughts on this? On Thu, Mar 20, 2025 at 5:30 PM Pranav Kant wrote: > Patch version v5: > - Uses two new macros DECLARE_ASM_VAR (used for both external and inline > asm) and DECLARE_EXTERNAL_ASM_VAR (used only for external asm) > - I intend to remove explicit existing use of attribute_visib

Re: [FFmpeg-devel] [PATCH v5] Mark C globals with small code model

2025-03-20 Thread Pranav Kant via ffmpeg-devel
Patch version v5: - Uses two new macros DECLARE_ASM_VAR (used for both external and inline asm) and DECLARE_EXTERNAL_ASM_VAR (used only for external asm) - I intend to remove explicit existing use of attribute_visibility_hidden in follow-up patch and instead use DECLARE_EXTERNAL_ASM_VAR for those v