On Sun, 24 Jan 2016 13:44:47 +
Mark Thompson wrote:
> ...
> >> +
> >> +vas = vaSyncSurface(hw_ctx->display, surface->id);
> >
> > Is this strictly needed? (I don't know.)
>
> It's definitely needed in some cases - the hwaccel decoder does not call
> vaSyncSurface(), so we have to s
On 24/01/16 12:29, wm4 wrote:
> On Sat, 23 Jan 2016 19:13:38 +
> Mark Thompson wrote:
>
>> ---
>> configure | 5 +
>> libavutil/Makefile | 1 +
>> libavutil/vaapi.c | 546
>> +
>> libavutil/vaapi.h | 115 +++
>> 4 fi
On 24/01/16 00:34, Timothy Gu wrote:
> On Sat, Jan 23, 2016 at 07:13:38PM +, Mark Thompson wrote:
>> +av_log(0, AV_LOG_ERROR, "Failed to destroy surface: "
>> + "%d (%s).\n", vas, vaErrorStr(vas));
>
> Maybe you can consider adding an AVClass just for logging. Either way
On Sun, 24 Jan 2016 13:58:59 +0100
Timo Rothenpieler wrote:
> >> +void *address;
> >> +// On current Intel drivers, derive gives you memory which is very
> >> slow
> >> +// to read (uncached?). It can be better for write-only cases, but
> >> for
> >> +// now play it safe and ne
>> +void *address;
>> +// On current Intel drivers, derive gives you memory which is very slow
>> +// to read (uncached?). It can be better for write-only cases, but for
>> +// now play it safe and never use derive.
>
> Still subject to debate when we introduce a "GPU memcpy".
>
On Sat, 23 Jan 2016 19:13:38 +
Mark Thompson wrote:
> ---
> configure | 5 +
> libavutil/Makefile | 1 +
> libavutil/vaapi.c | 546
> +
> libavutil/vaapi.h | 115 +++
> 4 files changed, 667 insertions(+)
> create mo
On Sat, 23 Jan 2016 16:34:45 -0800
Timothy Gu wrote:
> On Sat, Jan 23, 2016 at 07:13:38PM +, Mark Thompson wrote:
> > +av_log(0, AV_LOG_ERROR, "Failed to destroy surface: "
> > + "%d (%s).\n", vas, vaErrorStr(vas));
>
> Maybe you can consider adding an AVClass just fo
On Sat, Jan 23, 2016 at 07:13:38PM +, Mark Thompson wrote:
> +av_log(0, AV_LOG_ERROR, "Failed to destroy surface: "
> + "%d (%s).\n", vas, vaErrorStr(vas));
Maybe you can consider adding an AVClass just for logging. Either way the “0”
needs to be “NULL.”
Here and below.
