Re: [FFmpeg-devel] [PATCH v4 1/1] avformat: Add IPFS protocol support.

2022-02-12 Thread Tomas Härdin
ons 2022-02-09 klockan 18:36 +0100 skrev Mark Gaiser: > > > Thank you so much for all the valuable feedback! It's much > appreciated :) > > I'll fix all the still open issues and send another patch mail > somewhere > later this week. > Question though, as this seems to be heading towards the fina

Re: [FFmpeg-devel] [PATCH v4 1/1] avformat: Add IPFS protocol support.

2022-02-09 Thread Mark Gaiser
On Wed, Feb 9, 2022 at 6:36 PM Mark Gaiser wrote: > On Mon, Feb 7, 2022 at 4:09 PM Tomas Härdin wrote: > >> fre 2022-02-04 klockan 15:12 +0100 skrev Mark Gaiser: >> > On Fri, Feb 4, 2022 at 12:10 PM Tomas Härdin >> > wrote: >> > >> > > tor 2022-02-03 klockan 18:29 +0100 skrev Mark Gaiser: >> >

Re: [FFmpeg-devel] [PATCH v4 1/1] avformat: Add IPFS protocol support.

2022-02-09 Thread Mark Gaiser
On Mon, Feb 7, 2022 at 4:09 PM Tomas Härdin wrote: > fre 2022-02-04 klockan 15:12 +0100 skrev Mark Gaiser: > > On Fri, Feb 4, 2022 at 12:10 PM Tomas Härdin > > wrote: > > > > > tor 2022-02-03 klockan 18:29 +0100 skrev Mark Gaiser: > > > > > > > > +typedef struct IPFSGatewayContext { > > > > +

Re: [FFmpeg-devel] [PATCH v4 1/1] avformat: Add IPFS protocol support.

2022-02-07 Thread Tomas Härdin
fre 2022-02-04 klockan 15:12 +0100 skrev Mark Gaiser: > On Fri, Feb 4, 2022 at 12:10 PM Tomas Härdin > wrote: > > > tor 2022-02-03 klockan 18:29 +0100 skrev Mark Gaiser: > > > > > > +typedef struct IPFSGatewayContext { > > > +    AVClass *class; > > > +    URLContext *inner; > > > +    char *gat

Re: [FFmpeg-devel] [PATCH v4 1/1] avformat: Add IPFS protocol support.

2022-02-04 Thread Mark Gaiser
On Fri, Feb 4, 2022 at 12:10 PM Tomas Härdin wrote: > tor 2022-02-03 klockan 18:29 +0100 skrev Mark Gaiser: > > > > +typedef struct IPFSGatewayContext { > > +AVClass *class; > > +URLContext *inner; > > +char *gateway; > > Consider two separate variables. One for AVOption and one for t

Re: [FFmpeg-devel] [PATCH v4 1/1] avformat: Add IPFS protocol support.

2022-02-04 Thread Tomas Härdin
tor 2022-02-03 klockan 18:29 +0100 skrev Mark Gaiser: > > +typedef struct IPFSGatewayContext { > +    AVClass *class; > +    URLContext *inner; > +    char *gateway; Consider two separate variables. One for AVOption and one for the dynamically allocated string. Or put the latter on the stack. >