Re: [FFmpeg-devel] [PATCH v3 4/6] avformat/wavdec: s337m support

2019-08-08 Thread Gaullier Nicolas
>.. this won't compile if S377m is disabled. Just go with the old #if >solution, sorry for causing confusion My mistake but I think it is a good idea to get rid of some bulky #if... Do you think a mixed usage of if and #if would be acceptable ? I think the following would be the best : if (!C

Re: [FFmpeg-devel] [PATCH v3 4/6] avformat/wavdec: s337m support

2019-08-06 Thread Tomas Härdin
tis 2019-08-06 klockan 17:08 +0200 skrev Nicolas Gaullier: > Enabled by AVOption dolbyeprobe > Requires stereo > --- > libavformat/s337m.h | 1 + > libavformat/wavdec.c | 23 +++ > 2 files changed, 24 insertions(+) > > diff --git a/libavformat/s337m.h b/libavformat/s337m.h >