Re: [FFmpeg-devel] [PATCH v3] lavc/audiotoolboxenc: fix noise in encoded audio

2018-01-02 Thread James Almer
On 1/3/2018 1:02 AM, Jiejun Zhang wrote: > On Wed, Jan 3, 2018 at 10:02 AM, James Almer wrote: >> On 1/2/2018 1:24 PM, zhangjiejun1...@gmail.com wrote: >>> From: Jiejun Zhang >>> >>> This fixes #6940 >>> >>> Although undocumented, AudioToolbox seems to require the data supplied >>> by the callbac

Re: [FFmpeg-devel] [PATCH v3] lavc/audiotoolboxenc: fix noise in encoded audio

2018-01-02 Thread Jiejun Zhang
On Wed, Jan 3, 2018 at 10:02 AM, James Almer wrote: > On 1/2/2018 1:24 PM, zhangjiejun1...@gmail.com wrote: >> From: Jiejun Zhang >> >> This fixes #6940 >> >> Although undocumented, AudioToolbox seems to require the data supplied >> by the callback (i.e. ffat_encode_callback) being unchanged unti

Re: [FFmpeg-devel] [PATCH v3] lavc/audiotoolboxenc: fix noise in encoded audio

2018-01-02 Thread James Almer
On 1/2/2018 1:24 PM, zhangjiejun1...@gmail.com wrote: > From: Jiejun Zhang > > This fixes #6940 > > Although undocumented, AudioToolbox seems to require the data supplied > by the callback (i.e. ffat_encode_callback) being unchanged until the > next time the callback is called. In the old implem