Re: [FFmpeg-devel] [PATCH v3] avcodec: add Actimagine VX video decoder

2021-03-18 Thread Andreas Rheinhardt
Florian Nouwt: > Andreas Rheinhardt: > > - Why are these tables not internal to actimagine_vx.c? > > I separated the data because for parsing the vx container files I will > need a parser, which will be in a separate file from the decoder and > requires those tables. > > - You wasted an opportun

Re: [FFmpeg-devel] [PATCH v3] avcodec: add Actimagine VX video decoder

2021-03-18 Thread Florian Nouwt
Andreas Rheinhardt: - Why are these tables not internal to actimagine_vx.c? I separated the data because for parsing the vx container files I will need a parser, which will be in a separate file from the decoder and requires those tables. - You wasted an opportunity to add a space before '=' (th

Re: [FFmpeg-devel] [PATCH v3] avcodec: add Actimagine VX video decoder

2021-03-18 Thread Zane van Iperen
On 18/3/21 8:31 pm, Florian Nouwt wrote: diff --git a/libavformat/riff.c b/libavformat/riff.c index 270ff7c024..848b1d6cfd 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -496,6 +496,8 @@ const AVCodecTag ff_codec_bmp_tags[] = { { AV_CODEC_ID_MVHA, MKTAG('M', 'V', 'H',

Re: [FFmpeg-devel] [PATCH v3] avcodec: add Actimagine VX video decoder

2021-03-18 Thread Andreas Rheinhardt
Florian Nouwt: > Signed-off-by: Florian Nouwt > --- > Changelog |1 + > configure |1 + > doc/general_contents.texi |2 + > libavcodec/Makefile |3 +- > libavcodec/actimagine_vx.c | 1150 +++