Re: [FFmpeg-devel] [PATCH v3] Add support for Audible AA files

2015-07-28 Thread Michael Niedermayer
On Tue, Jul 28, 2015 at 04:21:12PM +, Carl Eugen Hoyos wrote: > Vesselin Bontchev yandex.com> writes: > > > +@example > > +ffmpeg -v debug -i input.aa -c:a copy output.wav > > I don't think this is a very useful example, instead > please document the option that the demuxer has in > short

Re: [FFmpeg-devel] [PATCH v3] Add support for Audible AA files

2015-07-28 Thread Vesselin Bontchev
28.07.2015, 19:23, "Carl Eugen Hoyos" : > Vesselin Bontchev yandex.com> writes: > >>  +@example >>  +ffmpeg -v debug -i input.aa -c:a copy output.wav > > I don't think this is a very useful example, instead > please document the option that the demuxer has in > short words (you don't have to docum

Re: [FFmpeg-devel] [PATCH v3] Add support for Audible AA files

2015-07-28 Thread Carl Eugen Hoyos
Vesselin Bontchev yandex.com> writes: > +@example > +ffmpeg -v debug -i input.aa -c:a copy output.wav I don't think this is a very useful example, instead please document the option that the demuxer has in short words (you don't have to document the default value imo). > + * Redistribution a

Re: [FFmpeg-devel] [PATCH v3] Add support for Audible AA files

2015-07-28 Thread Michael Niedermayer
On Tue, Jul 28, 2015 at 05:25:21PM +0300, Vesselin Bontchev wrote: > Hi, > > I am attaching a new revision (v3) of the "Audible AA" patch. > > Vesselin [...] > +avio_skip(pb, 24); // header termination block (ignored) > +npairs = avio_rb32(pb); // read dictionary entries > +for (i =