Re: [FFmpeg-devel] [PATCH v2 1/8] swscale: document SWS_FULL_CHR_H_* flags

2024-08-15 Thread Niklas Haas
On Thu, 04 Jul 2024 16:30:57 +0200 Niklas Haas wrote: > From: Niklas Haas > > Based on my best understanding of what they do, given the source code. > --- > libswscale/swscale.h | 28 ++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/libswscale/sw

Re: [FFmpeg-devel] [PATCH v2 1/8] swscale: document SWS_FULL_CHR_H_* flags

2024-07-04 Thread Andrew Sayers
On Thu, Jul 04, 2024 at 07:59:10PM +0200, Niklas Haas wrote: > On Thu, 04 Jul 2024 19:56:56 +0200 Niklas Haas wrote: > > On Thu, 04 Jul 2024 16:24:24 +0100 Andrew Sayers > > wrote: > > > On Thu, Jul 04, 2024 at 04:30:57PM +0200, Niklas Haas wrote: > > > > From: Niklas Haas > > > > > > > > Base

Re: [FFmpeg-devel] [PATCH v2 1/8] swscale: document SWS_FULL_CHR_H_* flags

2024-07-04 Thread Niklas Haas
On Thu, 04 Jul 2024 19:56:56 +0200 Niklas Haas wrote: > On Thu, 04 Jul 2024 16:24:24 +0100 Andrew Sayers > wrote: > > On Thu, Jul 04, 2024 at 04:30:57PM +0200, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > Based on my best understanding of what they do, given the source code. > > > --

Re: [FFmpeg-devel] [PATCH v2 1/8] swscale: document SWS_FULL_CHR_H_* flags

2024-07-04 Thread Niklas Haas
On Thu, 04 Jul 2024 16:24:24 +0100 Andrew Sayers wrote: > On Thu, Jul 04, 2024 at 04:30:57PM +0200, Niklas Haas wrote: > > From: Niklas Haas > > > > Based on my best understanding of what they do, given the source code. > > --- > > libswscale/swscale.h | 28 ++-- > > 1

Re: [FFmpeg-devel] [PATCH v2 1/8] swscale: document SWS_FULL_CHR_H_* flags

2024-07-04 Thread Andrew Sayers
On Thu, Jul 04, 2024 at 04:30:57PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Based on my best understanding of what they do, given the source code. > --- > libswscale/swscale.h | 28 ++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/libswsc

Re: [FFmpeg-devel] [PATCH v2 1/8] swscale: document SWS_FULL_CHR_H_* flags

2024-07-04 Thread Niklas Haas
Changes since v1: - Added commit relaxing the chr_v_pos value range in swscale to account for the existence of 4:1:1 / 4:1:0 content. - Fix the chroma location calculation for 4:1:1 / 4:1:0, including in interlaced mode. - Made the old (more granular) fields override the new one, rather than