Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-10-20 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2023-10-20 16:00:45) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2023-07-03 20:02:25) Marvin Scholz: > I honestly can't think of a sensible API design for this, > if you have any idea feel free to share. > The only way I

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-10-20 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-10-20 16:00:45) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2023-07-03 20:02:25) > >> Marvin Scholz: > >>> I honestly can't think of a sensible API design for this, > >>> if you have any idea feel free to share. > >>> > >> > >> The only way I can think of that

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-10-20 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2023-07-03 20:02:25) >> Marvin Scholz: >>> I honestly can't think of a sensible API design for this, >>> if you have any idea feel free to share. >>> >> >> The only way I can think of that allows this is for the user to pass a >> pointer to a (const) AVD

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-10-20 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-07-03 20:02:25) > Marvin Scholz: > > I honestly can't think of a sensible API design for this, > > if you have any idea feel free to share. > > > > The only way I can think of that allows this is for the user to pass a > pointer to a (const) AVDictionaryEntry, nam

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-07-03 Thread Marvin Scholz
On 3 Jul 2023, at 20:02, Andreas Rheinhardt wrote: > Marvin Scholz: >> >> >> On 3 Jul 2023, at 2:18, Andreas Rheinhardt wrote: >> >>> Marvin Scholz: This new API allows to remove an entry and obtain ownership of the key/value that was associated with the removed entry. --- >

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-07-03 Thread Andreas Rheinhardt
Marvin Scholz: > > > On 3 Jul 2023, at 2:18, Andreas Rheinhardt wrote: > >> Marvin Scholz: >>> This new API allows to remove an entry and obtain ownership of the >>> key/value that was associated with the removed entry. >>> --- >>> >>> Changes since v1: >>> - Clarify documentation about av_free

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-07-03 Thread Marvin Scholz
On 3 Jul 2023, at 2:18, Andreas Rheinhardt wrote: > Marvin Scholz: >> This new API allows to remove an entry and obtain ownership of the >> key/value that was associated with the removed entry. >> --- >> >> Changes since v1: >> - Clarify documentation about av_free having to be used. >> - Fix f

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-07-02 Thread Andreas Rheinhardt
Marvin Scholz: > This new API allows to remove an entry and obtain ownership of the > key/value that was associated with the removed entry. > --- > > Changes since v1: > - Clarify documentation about av_free having to be used. > - Fix fate test to not rely on specific error code value > > doc/AP

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-07-02 Thread Marvin Scholz
On 2 Jul 2023, at 10:43, Stefano Sabatini wrote: > On date Sunday 2023-06-25 12:49:05 +0200, Marvin Scholz wrote: >> This new API allows to remove an entry and obtain ownership of the >> key/value that was associated with the removed entry. >> --- >> >> Changes since v1: >> - Clarify documentation

Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop

2023-07-02 Thread Stefano Sabatini
On date Sunday 2023-06-25 12:49:05 +0200, Marvin Scholz wrote: > This new API allows to remove an entry and obtain ownership of the > key/value that was associated with the removed entry. > --- > > Changes since v1: > - Clarify documentation about av_free having to be used. > - Fix fate test to no