Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Mats Peterson
On 12/30/2015 05:47 AM, Mats Peterson wrote: The original .mov file has the grayscale bit set in the bit depth field of the video sample description, but since that seemed highly illogical to me, I cleared it for the purposes of this demonstration. For some reason, QuickTime in Win or Mac seems

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Mats Peterson
On 12/30/2015 05:25 AM, Mats Peterson wrote: On 12/30/2015 04:38 AM, Carl Eugen Hoyos wrote: Michael Niedermayer niedermayer.cc> writes: md5sum Earth\ Spin\ 1-bit\ qtrle.mov 2a73988ea94a1201a9cf477d71d3ff29 Earth Spin 1-bit qtrle.mov Mats has indeed decided to offer different files with the

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Mats Peterson
On 12/30/2015 04:38 AM, Carl Eugen Hoyos wrote: Michael Niedermayer niedermayer.cc> writes: md5sum Earth\ Spin\ 1-bit\ qtrle.mov 2a73988ea94a1201a9cf477d71d3ff29 Earth Spin 1-bit qtrle.mov Mats has indeed decided to offer different files with the same name for download. I suggest we test the

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Mats Peterson
On 12/30/2015 05:19 AM, Mats Peterson wrote: Carl, perhaps you missed to compile MPlayer using the very latest FFmpeg? Mats Forget that suggestion, I thought the patch was applied already. In any case, I have patched qtrle.c in both FFmpeg and MPlayer here, and the rotating earth movie is

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Mats Peterson
On 12/30/2015 01:26 AM, Carl Eugen Hoyos wrote: Michael Niedermayer niedermayer.cc> writes: i tested with ffplay, and there it works I tested the following: $ git checkout b0e23f2a37b45e8fa7e9ae91301d0ef572e80181 $ wget http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151229/c12907af/a

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Mats Peterson
On 12/30/2015 12:43 AM, Michael Niedermayer wrote: it works with the now available patch fixing the decoder and the Earth\ Spin\ 1-bit\ qtrle.mov file I dont know if bugs remain, if there are any bugs/issues left, they should be fixed of course ... I don't know what he's doing on his side. B

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > md5sum Earth\ Spin\ 1-bit\ qtrle.mov > 2a73988ea94a1201a9cf477d71d3ff29 Earth Spin 1-bit qtrle.mov Mats has indeed decided to offer different files with the same name for download. I suggest we test the original unchanged file. (Although it's of cou

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Michael Niedermayer
On Wed, Dec 30, 2015 at 12:26:30AM +, Carl Eugen Hoyos wrote: > Michael Niedermayer niedermayer.cc> writes: > > > i tested with ffplay, and there it works > > I tested the following: > $ git checkout b0e23f2a37b45e8fa7e9ae91301d0ef572e80181 > $ wget > http://ffmpeg.org/pipermail/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > i tested with ffplay, and there it works I tested the following: $ git checkout b0e23f2a37b45e8fa7e9ae91301d0ef572e80181 $ wget http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151229/c12907af/attachment.bin $ md5sum attachment.bin 1656289c6533

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Michael Niedermayer
On Wed, Dec 30, 2015 at 12:12:31AM +, Carl Eugen Hoyos wrote: > Michael Niedermayer niedermayer.cc> writes: > > > > > On Wed, Dec 30, 2015 at 12:00:20AM +, Carl Eugen Hoyos wrote: > > > Michael Niedermayer niedermayer.cc> writes: > > > > > > > > If you cannot test, how do you know it i

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > > On Wed, Dec 30, 2015 at 12:00:20AM +, Carl Eugen Hoyos wrote: > > Michael Niedermayer niedermayer.cc> writes: > > > > > > If you cannot test, how do you know it is correct? > > > > > > it works with the now available patch fixing the decoder

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Michael Niedermayer
On Wed, Dec 30, 2015 at 12:00:20AM +, Carl Eugen Hoyos wrote: > Michael Niedermayer niedermayer.cc> writes: > > > > If you cannot test, how do you know it is correct? > > > > it works with the now available patch fixing the decoder and the > > Earth\ Spin\ 1-bit\ qtrle.mov > > file > > Sorr

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > > If you cannot test, how do you know it is correct? > > it works with the now available patch fixing the decoder and the > Earth\ Spin\ 1-bit\ qtrle.mov > file Sorry, it seems I am very slow today: What does "it works" mean here? Carl Eugen _

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Michael Niedermayer
On Tue, Dec 29, 2015 at 05:42:26PM +, Carl Eugen Hoyos wrote: > Michael Niedermayer niedermayer.cc> writes: > > > On Tue, Dec 29, 2015 at 04:56:26PM +, Carl Eugen Hoyos wrote: > > > Michael Niedermayer niedermayer.cc> writes: > > > > > > > > https://drive.google.com/open?id=0B3_pEBoLs0f

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Mats Peterson
On 12/29/2015 06:42 PM, Carl Eugen Hoyos wrote: Michael Niedermayer niedermayer.cc> writes: On Tue, Dec 29, 2015 at 04:56:26PM +, Carl Eugen Hoyos wrote: Michael Niedermayer niedermayer.cc> writes: https://drive.google.com/open?id=0B3_pEBoLs0faUlItWm9KaGJSTEE patch applied How exac

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > On Tue, Dec 29, 2015 at 04:56:26PM +, Carl Eugen Hoyos wrote: > > Michael Niedermayer niedermayer.cc> writes: > > > > > > https://drive.google.com/open?id=0B3_pEBoLs0faUlItWm9KaGJSTEE > > > > > > patch applied > > > > How exactly did you test

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Michael Niedermayer
On Tue, Dec 29, 2015 at 04:56:26PM +, Carl Eugen Hoyos wrote: > Michael Niedermayer niedermayer.cc> writes: > > > > https://drive.google.com/open?id=0B3_pEBoLs0faUlItWm9KaGJSTEE > > > > patch applied > > How exactly did you test this? it is neccessary to also fix the decoder to test, this

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > > https://drive.google.com/open?id=0B3_pEBoLs0faUlItWm9KaGJSTEE > > patch applied How exactly did you test this? Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Mats Peterson
On 12/29/2015 11:56 AM, Michael Niedermayer wrote: On Tue, Dec 29, 2015 at 07:38:04AM +0100, Mats Peterson wrote: I forgot some stuff. Patch description follows: This patch for qtpalette.c and qtpalette.h adds 1-bit video to the "palettized video" category, since if the video sample description

Re: [FFmpeg-devel] [PATCH v2] lavf/qtpalette: Treat 1-bit video as palettized

2015-12-29 Thread Michael Niedermayer
On Tue, Dec 29, 2015 at 07:38:04AM +0100, Mats Peterson wrote: > I forgot some stuff. Patch description follows: > > This patch for qtpalette.c and qtpalette.h adds 1-bit video to the > "palettized video" category, since if the video sample description > contains a palette, the two colors in the p