Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Detect subpic overlaps at CTU level

2025-05-24 Thread Nuo Mi
On Sun, May 18, 2025 at 9:16 PM Frank Plowman wrote: > On 29/04/2025 14:24, Nuo Mi wrote: > > Hi Frank, > > Thank you for the detail. > > > > On Mon, Apr 28, 2025 at 10:35 PM Frank Plowman > > wrote: > > > >> On 28/04/2025 14:33, Nuo Mi wrote: > >>> Hi Frank, > >>> Thank you for the v2. > >>> Co

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Detect subpic overlaps at CTU level

2025-05-18 Thread Frank Plowman
On 29/04/2025 14:24, Nuo Mi wrote: > Hi Frank, > Thank you for the detail. > > On Mon, Apr 28, 2025 at 10:35 PM Frank Plowman > wrote: > >> On 28/04/2025 14:33, Nuo Mi wrote: >>> Hi Frank, >>> Thank you for the v2. >>> Could we remove all asserts? >>> Asserts can cause the application to crash a

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Detect subpic overlaps at CTU level

2025-04-29 Thread Nuo Mi
Hi Frank, Thank you for the detail. On Mon, Apr 28, 2025 at 10:35 PM Frank Plowman wrote: > On 28/04/2025 14:33, Nuo Mi wrote: > > Hi Frank, > > Thank you for the v2. > > Could we remove all asserts? > > Asserts can cause the application to crash at runtime. > > Hi, > > I think av_assert2s are t

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Detect subpic overlaps at CTU level

2025-04-28 Thread Frank Plowman
On 28/04/2025 14:33, Nuo Mi wrote: > Hi Frank, > Thank you for the v2. > Could we remove all asserts? > Asserts can cause the application to crash at runtime. Hi, I think av_assert2s are the right thing to use here. In case it was not clear, these asserts should never be triggered by any bitstre

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Detect subpic overlaps at CTU level

2025-04-28 Thread Nuo Mi
Hi Frank, Thank you for the v2. Could we remove all asserts? Asserts can cause the application to crash at runtime. On Sun, Apr 27, 2025 at 4:48 PM Frank Plowman wrote: > In d5dbcc00d889fb17948b025a468b00ddbea9e058, it was hoped that detection > of subpicture overlaps could be performed at the t