Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: deprecate hls_wrap option

2017-02-09 Thread Steven Liu
2017-02-09 18:53 GMT+08:00 Carl Eugen Hoyos : > 2017-02-09 11:52 GMT+01:00 Steven Liu : > > 2017-02-09 18:46 GMT+08:00 Carl Eugen Hoyos : > > > >> 2017-02-09 8:58 GMT+01:00 Steven Liu : > >> > >> > +#if FF_API_HLS_WRAP > >> > {"hls_wrap", "set number after which the index wraps", > >> OF

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: deprecate hls_wrap option

2017-02-09 Thread Carl Eugen Hoyos
2017-02-09 11:52 GMT+01:00 Steven Liu : > 2017-02-09 18:46 GMT+08:00 Carl Eugen Hoyos : > >> 2017-02-09 8:58 GMT+01:00 Steven Liu : >> >> > +#if FF_API_HLS_WRAP >> > {"hls_wrap", "set number after which the index wraps", >> OFFSET(wrap),AV_OPT_TYPE_INT,{.i64 = 0}, 0, INT_MAX,

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: deprecate hls_wrap option

2017-02-09 Thread Steven Liu
2017-02-09 18:46 GMT+08:00 Carl Eugen Hoyos : > 2017-02-09 8:58 GMT+01:00 Steven Liu : > > > +#if FF_API_HLS_WRAP > > {"hls_wrap", "set number after which the index wraps", > OFFSET(wrap),AV_OPT_TYPE_INT,{.i64 = 0}, 0, INT_MAX, E}, > > +#endif > > (Even if this is not done fo

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: deprecate hls_wrap option

2017-02-09 Thread Carl Eugen Hoyos
2017-02-09 8:58 GMT+01:00 Steven Liu : > +#if FF_API_HLS_WRAP > {"hls_wrap", "set number after which the index wraps", > OFFSET(wrap),AV_OPT_TYPE_INT,{.i64 = 0}, 0, INT_MAX, E}, > +#endif (Even if this is not done for other deprecated options:) Imo, either add the word dep