Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-24 Thread Dong, Ruijing
[AMD Official Use Only - General] Thanks for the input. I will try this way. Ruijing -Original Message- From: Mark Thompson Sent: Thursday, November 24, 2022 4:10 PM To: Dong, Ruijing ; FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-24 Thread Mark Thompson
On 24/11/2022 15:27, Dong, Ruijing wrote: [AMD Official Use Only - General] I might have misunderstood some of the questions, and I would like to explain more about the issue from my perspective, please correct me if anything wrong. Are you perhaps missing that this is intended to be a common

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-24 Thread Dong, Ruijing
- From: ffmpeg-devel On Behalf Of Dong, Ruijing Sent: Tuesday, November 22, 2022 9:43 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode [AMD Official Use Only - General] [AMD Official Use Only - General] H

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Dong, Ruijing
] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode On 22/11/2022 20:59, Mark Thompson wrote: > On 22/11/2022 20:26, Mark Thompson wrote: >> On 22/11/2022 19:18, Dong, Ruijing wrote: >>> [AMD Official Use Only - General] >>> >>> Hi Mark, >>

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Mark Thompson
On 22/11/2022 20:59, Mark Thompson wrote: On 22/11/2022 20:26, Mark Thompson wrote: On 22/11/2022 19:18, Dong, Ruijing wrote: [AMD Official Use Only - General] Hi Mark, Sorry for being late to reply to you. Your understanding is correct, and I have sent a new patch [v4] for addressing the c

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Mark Thompson
nal Message- From: ffmpeg-devel On Behalf Of Mark Thompson Sent: Sunday, November 20, 2022 11:44 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode On 20/11/2022 02:59, Ruijing Dong wrote: Adding direct film grain mode for av1 dec

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Mark Thompson
it to the correct one instead? - Mark -Original Message- From: ffmpeg-devel On Behalf Of Mark Thompson Sent: Sunday, November 20, 2022 11:44 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode On 20/11/2022 02:59, Ruijing

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Dong, Ruijing
, November 20, 2022 11:44 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode On 20/11/2022 02:59, Ruijing Dong wrote: > Adding direct film grain mode for av1 decoder, which outputs alongside > film grain. > > AV_HWACCEL_FLAG_DIREC

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-20 Thread Mark Thompson
On 20/11/2022 02:59, Ruijing Dong wrote: Adding direct film grain mode for av1 decoder, which outputs alongside film grain. AV_HWACCEL_FLAG_DIRECT_FILM_GRAIN is the new flag introduced to enable this path. issue: By using AMD av1 decoder via VAAPI, when used with film grain content, the output