Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-28 Thread Evgeny Pavlov
> > > Seems like we could template this to avoid the duplication, something like: > > #define PER_CODEC_OPTION(name) \ >(ctx->codec == AV1 ? AMF_VIDEO_ENCODER_AV1_ ## name : \ > ctx->codec == HEVC ? AMF_VIDEO_ENCODER_HEVC_ ## name : \ > AMF_VIDEO_ENCODER_ ##

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-27 Thread Mark Thompson
On 26/11/2023 14:40, Dmitrii Ovchinnikov wrote: The code looks significantly duplicated. This is not moved to amfenc.c since the property has different names for different encoders, and many other properties (also common to different encoders, but with different names) are separated in this w

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-27 Thread Mark Thompson
On 23/11/2023 09:41, Evgeny Pavlov wrote: This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-b

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-26 Thread Dmitrii Ovchinnikov
>> The code looks significantly duplicated. This is not moved to amfenc.c since the property has different names for different encoders, and many other properties (also common to different encoders, but with different names) are separated in this way. _

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-26 Thread Anton Khirnov
Quoting Dmitrii Ovchinnikov (2023-11-24 09:45:14) > If there are no objections, I would like to merge it in 2-3 days The code looks significantly duplicated. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mai

Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-24 Thread Dmitrii Ovchinnikov
If there are no objections, I would like to merge it in 2-3 days ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] [PATCH, v2] avcodec/amfenc: add smart access video option

2023-11-20 Thread Evgeny Pavlov
On Mon, Jul 24, 2023 at 1:25 PM Evgeny Pavlov wrote: > This commit adds option for enabling SmartAccess Video (SAV) > in AMF encoders. SAV is an AMD hardware-specific feature which > enables the parallelization of encode and decode streams across > multiple Video Codec Engine (VCN) hardware insta