Re: [FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-13 Thread Jan Ekström
On Wed, Feb 10, 2021 at 9:16 AM Bohan Li wrote: > > Hi Jan, > > Yes the modified patch looks good to me. > Please let me know if there is anything needed from my end. > > Thank you very much! > > Bohan > FYI, apparently the symbol is not exported in shared builds of libaom. I did test that versio

Re: [FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-10 Thread Jan Ekström
On Wed, Feb 10, 2021 at 9:16 AM Bohan Li wrote: > > Hi Jan, > > Yes the modified patch looks good to me. > Please let me know if there is anything needed from my end. > > Thank you very much! > > Bohan > Cheers, pulled in as 82aab8a4eec33ee92c92c7679a4d7e6f03b109b4 . Jan

Re: [FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-09 Thread Bohan Li
Hi Jan, Yes the modified patch looks good to me. Please let me know if there is anything needed from my end. Thank you very much! Bohan On Tue, Feb 9, 2021, 12:01 PM Jan Ekström wrote: > On Tue, Feb 9, 2021 at 6:05 AM Bohan Li > wrote: > > > > This key & value API can greatly help with users

Re: [FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-09 Thread Jan Ekström
On Tue, Feb 9, 2021 at 6:05 AM Bohan Li wrote: > > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported by ffmpeg options. > Looks good to me code-wise at this point. Thanks for noticing the small issues I had created due to not te

Re: [FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
Thanks for the info! Just uploaded the patch v2 as suggested. Best, Bohan On Mon, Feb 8, 2021 at 8:04 PM Bohan Li wrote: > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported by ffmpeg options. > > As was previously discussed in