Re: [FFmpeg-devel] [PATCH v17] avformat/dashdec: add dash demuxer base version

2017-08-30 Thread Steven Liu
2017-08-30 19:50 GMT+08:00 Timo Rothenpieler : >>> Just wanted to point out, as stated on IRC, that dashenc already has a >>> function that seems to safely solve the filename template issue, and >>> looks >>> like it can be moved into a common file + header, and reused as is: >>> >>> >>> http://git

Re: [FFmpeg-devel] [PATCH v17] avformat/dashdec: add dash demuxer base version

2017-08-30 Thread Steven Liu
2017-08-30 19:50 GMT+08:00 Timo Rothenpieler : >>> Just wanted to point out, as stated on IRC, that dashenc already has a >>> function that seems to safely solve the filename template issue, and >>> looks >>> like it can be moved into a common file + header, and reused as is: >>> >>> >>> http://git

Re: [FFmpeg-devel] [PATCH v17] avformat/dashdec: add dash demuxer base version

2017-08-30 Thread Timo Rothenpieler
Just wanted to point out, as stated on IRC, that dashenc already has a function that seems to safely solve the filename template issue, and looks like it can be moved into a common file + header, and reused as is: http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavformat/dashenc.c;h=bdb332c71ab4

Re: [FFmpeg-devel] [PATCH v17] avformat/dashdec: add dash demuxer base version

2017-08-30 Thread Steven Liu
2017-08-30 17:43 GMT+08:00 Timo Rothenpieler : >> v16 fixed: >> 1. remove the snprintf and instead by get_segment_filename make safety >> 2. remove unnecessary loops >> 3. updated xmlStrcmp and xmlFree to av_* functions >> 4. merge code repeat into one function >> 5. add memory alloc faild check >>

Re: [FFmpeg-devel] [PATCH v17] avformat/dashdec: add dash demuxer base version

2017-08-30 Thread Timo Rothenpieler
v16 fixed: 1. remove the snprintf and instead by get_segment_filename make safety 2. remove unnecessary loops 3. updated xmlStrcmp and xmlFree to av_* functions 4. merge code repeat into one function 5. add memory alloc faild check 6. update update_init_section and open_url 7. output safety error