Re: [FFmpeg-devel] [PATCH v11 1/3] libavcodec/dnxucdec: DNxUncompressed decoder

2024-10-11 Thread Michael Niedermayer
Hi Martin On Fri, Oct 11, 2024 at 04:12:54PM +0200, Martin Schitter wrote: > On 11.10.24 10:57, Anton Khirnov wrote: [...] > But I immediately stumbled again over another nasty swscale related bug! :( > > Just try it yourself: > > First make a simple test with my last posted patch set: > > ./

Re: [FFmpeg-devel] [PATCH v11 1/3] libavcodec/dnxucdec: DNxUncompressed decoder

2024-10-11 Thread Martin Schitter
On 11.10.24 10:57, Anton Khirnov wrote: It seems rather obvious to me - you're making a demuxer export something that IS raw video, yet you're tagging it as a new codec ID with a new decoder that (for these specific pixel format) duplicates what the rawvideo decoder does. Just to be clear, I

Re: [FFmpeg-devel] [PATCH v11 1/3] libavcodec/dnxucdec: DNxUncompressed decoder

2024-10-11 Thread Anton Khirnov
Quoting Martin Schitter (2024-10-11 03:08:23) > On 10.10.24 14:13, Anton Khirnov wrote: > > I've already commented on this in a previous version - this should be > > directly exported as rawvideo by the demuxer rather than requiring a > > special encoder. > > > hmm -- you touched this topic once

Re: [FFmpeg-devel] [PATCH v11 1/3] libavcodec/dnxucdec: DNxUncompressed decoder

2024-10-10 Thread Martin Schitter
On 10.10.24 14:13, Anton Khirnov wrote: Quoting Martin Schitter (2024-10-10 04:58:40) +static int pass_though(AVCodecContext *avctx, AVFrame *frame, const AVPacket *avpkt) +{ +/* there is no need to copy as the data already match + * a known pixel format */ + +frame->buf[0] = av_

Re: [FFmpeg-devel] [PATCH v11 1/3] libavcodec/dnxucdec: DNxUncompressed decoder

2024-10-10 Thread Anton Khirnov
Quoting Martin Schitter (2024-10-10 04:58:40) > +static int pass_though(AVCodecContext *avctx, AVFrame *frame, const AVPacket > *avpkt) > +{ > +/* there is no need to copy as the data already match > + * a known pixel format */ > + > +frame->buf[0] = av_buffer_ref(avpkt->buf); > + > +