Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-14 Thread Michael Niedermayer
On Sat, Feb 07, 2015 at 04:14:11PM +0100, Christophe Gisquet wrote: > Hi, > > 2015-02-06 18:33 GMT+01:00 James Almer : > > Yes, that should do it. > > > > And for that matter you were right, it should be "4, 6". I was reading it > > as regs > > loaded when the second argument is regs needed. > >

Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-07 Thread Christophe Gisquet
Hi, 2015-02-06 18:33 GMT+01:00 James Almer : > Yes, that should do it. > > And for that matter you were right, it should be "4, 6". I was reading it as > regs > loaded when the second argument is regs needed. Ok, here's an updated patch. I also fixed the unneeded mov on UNIX64, as height is alr

Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-06 Thread James Almer
On 06/02/15 1:05 PM, Christophe Gisquet wrote: > 2015-02-06 16:18 GMT+01:00 James Almer : >> "mov r5d, denomm" is loading it on Win64. It's also a superfluous >> instruction on >> UNIX64, where it translates to "mov r5d, r5d". >> At least if i'm reading this right. > > movifnidn then? Yes, that

Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-06 Thread Christophe Gisquet
2015-02-06 16:18 GMT+01:00 James Almer : > "mov r5d, denomm" is loading it on Win64. It's also a superfluous instruction > on > UNIX64, where it translates to "mov r5d, r5d". > At least if i'm reading this right. movifnidn then? -- Christophe ___ ffmp

Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-06 Thread James Almer
On 06/02/15 6:14 AM, Christophe Gisquet wrote: > 2015-02-05 20:20 GMT+01:00 Christophe Gisquet : >> > -cglobal hevc_put_hevc_bi_w%1_%2, 5, 7, 10, dst, dststride, src, >> > srcstride, src2, height, denom, wx0, wx1, ox0, ox1 >> > -mov r6d, denomm >> > +cglobal hevc_put_hevc_bi_w%1_%

Re: [FFmpeg-devel] [PATCH 7/7] x86: hevc: remove a parameter to WP internals

2015-02-06 Thread Christophe Gisquet
2015-02-05 20:20 GMT+01:00 Christophe Gisquet : > -cglobal hevc_put_hevc_bi_w%1_%2, 5, 7, 10, dst, dststride, src, srcstride, > src2, height, denom, wx0, wx1, ox0, ox1 > -mov r6d, denomm > +cglobal hevc_put_hevc_bi_w%1_%2, 4, 5, 10, dst, dststride, src, src2, > height, denom, wx0