Re: [FFmpeg-devel] [PATCH 6/7] lavfi/framesync2: implement activate design.

2017-07-18 Thread Derek Buitenhuis
On 7/18/2017 3:30 PM, Paul B Mahol wrote: > I actually like this 'design', as its more like VS one. I wasn't commenting on the code/design itself, but the commit message, or rather, lack thereof. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] [PATCH 6/7] lavfi/framesync2: implement activate design.

2017-07-18 Thread Paul B Mahol
On 7/18/17, Derek Buitenhuis wrote: > On 7/17/2017 3:19 PM, Nicolas George wrote: >> Signed-off-by: Nicolas George >> --- >> libavfilter/framesync2.c | 166 >> +++ >> libavfilter/framesync2.h | 77 -- >> 2 files changed, 82 inserti

Re: [FFmpeg-devel] [PATCH 6/7] lavfi/framesync2: implement activate design.

2017-07-18 Thread Derek Buitenhuis
On 7/17/2017 3:19 PM, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/framesync2.c | 166 > +++ > libavfilter/framesync2.h | 77 -- > 2 files changed, 82 insertions(+), 161 deletions(-) So what does this