Re: [FFmpeg-devel] [PATCH 5/6] avcodec/mpeg4videodec: Remove always-true checks

2022-10-13 Thread Michael Niedermayer
On Thu, Oct 13, 2022 at 11:23:33PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Hi > > > > On Wed, Oct 12, 2022 at 08:06:22PM +0200, Andreas Rheinhardt wrote: > >> codec_id is always AV_CODEC_ID_MPEG4 in this file. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcod

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/mpeg4videodec: Remove always-true checks

2022-10-13 Thread Andreas Rheinhardt
Michael Niedermayer: > Hi > > On Wed, Oct 12, 2022 at 08:06:22PM +0200, Andreas Rheinhardt wrote: >> codec_id is always AV_CODEC_ID_MPEG4 in this file. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/mpeg4videodec.c | 6 ++ >> 1 file changed, 2 insertions(+), 4 deletions(-) > [.

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/mpeg4videodec: Remove always-true checks

2022-10-13 Thread Michael Niedermayer
Hi On Wed, Oct 12, 2022 at 08:06:22PM +0200, Andreas Rheinhardt wrote: > codec_id is always AV_CODEC_ID_MPEG4 in this file. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg4videodec.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) [...] > @@ -3084,7 +3083,6 @@ int ff