Re: [FFmpeg-devel] [PATCH 5/5] Add AudioToolbox audio input device.

2022-01-29 Thread Romain Beauxis
Le sam. 29 janv. 2022 à 14:42, Andreas Rheinhardt a écrit : > > Romain Beauxis: > > Le mer. 19 janv. 2022 à 10:59, Marvin Scholz a écrit : > >> > >> > >> > >> On 19 Jan 2022, at 15:42, Romain Beauxis wrote: > >> > >> Hi, thanks for the patch. I've not done a full code review yet, just a > >> few

Re: [FFmpeg-devel] [PATCH 5/5] Add AudioToolbox audio input device.

2022-01-29 Thread Andreas Rheinhardt
Romain Beauxis: > Le mer. 19 janv. 2022 à 10:59, Marvin Scholz a écrit : >> >> >> >> On 19 Jan 2022, at 15:42, Romain Beauxis wrote: >> >> Hi, thanks for the patch. I've not done a full code review yet, just a >> few >> initial remarks below: >> >>> This patch adds support for a new, audio-specifi

Re: [FFmpeg-devel] [PATCH 5/5] Add AudioToolbox audio input device.

2022-01-29 Thread Romain Beauxis
Le mer. 19 janv. 2022 à 10:59, Marvin Scholz a écrit : > > > > On 19 Jan 2022, at 15:42, Romain Beauxis wrote: > > Hi, thanks for the patch. I've not done a full code review yet, just a > few > initial remarks below: > > > This patch adds support for a new, audio-specific input device using > > th

Re: [FFmpeg-devel] [PATCH 5/5] Add AudioToolbox audio input device.

2022-01-24 Thread Romain Beauxis
Le lun. 24 janv. 2022 à 10:19, Marvin Scholz a écrit : > > > > On 24 Jan 2022, at 16:42, Romain Beauxis wrote: > > > Hi Marvin, > > > > Le mer. 19 janv. 2022 à 10:59, Marvin Scholz a > > écrit : > >> On 19 Jan 2022, at 15:42, Romain Beauxis wrote: > >> > >> Hi, thanks for the patch. I've not done

Re: [FFmpeg-devel] [PATCH 5/5] Add AudioToolbox audio input device.

2022-01-24 Thread Marvin Scholz
On 24 Jan 2022, at 16:42, Romain Beauxis wrote: Hi Marvin, Le mer. 19 janv. 2022 à 10:59, Marvin Scholz a écrit : On 19 Jan 2022, at 15:42, Romain Beauxis wrote: Hi, thanks for the patch. I've not done a full code review yet, just a few initial remarks below: This patch adds support f

Re: [FFmpeg-devel] [PATCH 5/5] Add AudioToolbox audio input device.

2022-01-24 Thread Romain Beauxis
Hi Marvin, Le mer. 19 janv. 2022 à 10:59, Marvin Scholz a écrit : > On 19 Jan 2022, at 15:42, Romain Beauxis wrote: > > Hi, thanks for the patch. I've not done a full code review yet, just a > few > initial remarks below: > > > This patch adds support for a new, audio-specific input device using

Re: [FFmpeg-devel] [PATCH 5/5] Add AudioToolbox audio input device.

2022-01-19 Thread Marvin Scholz
On 19 Jan 2022, at 15:42, Romain Beauxis wrote: Hi, thanks for the patch. I've not done a full code review yet, just a few initial remarks below: This patch adds support for a new, audio-specific input device using the documented and battle-tested AUHAL input. This provides a pendant to th