Re: [FFmpeg-devel] [PATCH 3/6] avformat/s337m: New ff_s337m_probe()

2023-02-21 Thread Nicolas Gaullier
>> ff_s337m_probe is very similar to s337m_probe: what mainly differs is >> the input parameters. >> The one little thing I added is the S337M_PROBE_GUARDBAND_MIN_BYTES. >> Currently it is set to 0, so has no effect (and of course I can remove >> it if someone object). >> There is two things to k

Re: [FFmpeg-devel] [PATCH 3/6] avformat/s337m: New ff_s337m_probe()

2023-02-21 Thread Tomas Härdin
fre 2023-02-17 klockan 10:12 + skrev Nicolas Gaullier: > > The logic here is a bit hairy and I don't have time atm to digest > > it, but is it entirely contained in S337m or would one need to read > > other specs too? > > > > /Tomas > > ff_s337m_probe is very similar to s337m_probe: what main

Re: [FFmpeg-devel] [PATCH 3/6] avformat/s337m: New ff_s337m_probe()

2023-02-17 Thread Nicolas Gaullier
> The logic here is a bit hairy and I don't have time atm to digest it, but is > it entirely contained in S337m or would one need to read other specs too? > >/Tomas ff_s337m_probe is very similar to s337m_probe: what mainly differs is the input parameters. The one little thing I added is the S33

Re: [FFmpeg-devel] [PATCH 3/6] avformat/s337m: New ff_s337m_probe()

2023-02-16 Thread Tomas Härdin
mån 2023-02-13 klockan 19:09 +0100 skrev Nicolas Gaullier: > +    do { > +    uint64_t state; > +    int data_type, data_size, offset; > +    while (pos < size - 12 && !buf[pos]) { > +    pos++; > +    } > +    if (pos >= size - 12 || pos < > S337M_PROBE_GUARDBAND_MIN_BY