On Thu, Aug 14, 2014 at 12:03:25PM +0200, Christophe Gisquet wrote:
> Hi,
>
> 2014-08-12 12:44 GMT+02:00 Christophe Gisquet :
> > Forgot a parameter to the call to avpriv_request_sample, will be added
> > later.
>
> If there's no further comment on this option for the reallocation,
> here's an u
Hi,
2014-08-12 12:44 GMT+02:00 Christophe Gisquet :
> Forgot a parameter to the call to avpriv_request_sample, will be added later.
If there's no further comment on this option for the reallocation,
here's an updated patch.
--
Christophe
From 4ea51dc2cec915ce4c84db92febd8960bb44b650 Mon Sep 17
Hi,
2014-08-12 12:38 GMT+02:00 Christophe Gisquet :
> I chose 2 times in the attached patch. I have no strong opinion on
> which solution is best, though reallocating was a specific request I
> got.
Forgot a parameter to the call to avpriv_request_sample, will be added later.
--
Christophe
Hi,
2014-08-12 12:26 GMT+02:00 Michael Niedermayer :
> On Tue, Aug 12, 2014 at 11:56:21AM +0200, Christophe Gisquet wrote:
>> Hi,
>>
>> 2014-08-12 10:19 GMT+02:00 Michael Niedermayer :
>> > the "serious undersizing" check already depends on the assumtation
>> > that FF_MIN_BUFFER_SIZE is larger th
On Tue, Aug 12, 2014 at 11:56:21AM +0200, Christophe Gisquet wrote:
> Hi,
>
> 2014-08-12 10:19 GMT+02:00 Michael Niedermayer :
> > the "serious undersizing" check already depends on the assumtation
> > that FF_MIN_BUFFER_SIZE is larger than a slice,
>
> Yes, and here lies the issue: if we haven't
Hi,
2014-08-12 10:19 GMT+02:00 Michael Niedermayer :
> the "serious undersizing" check already depends on the assumtation
> that FF_MIN_BUFFER_SIZE is larger than a slice,
Yes, and here lies the issue: if we haven't been able to guess it
correctly previously, how likely are we to guess it correct
On Tue, Aug 12, 2014 at 07:56:36AM +0200, Christophe Gisquet wrote:
> Hi,
>
> 2014-08-12 2:34 GMT+02:00 Michael Niedermayer :
> >> +if (pkt_size <= buf - orig_buf) {
> >
> > this isnt sufficient, there could be 1 byte space left, then the
> > reallocate wouldnt run and encode_slice
2014-08-12 7:56 GMT+02:00 Christophe Gisquet :
> Yeah, you're right. I have no idea how big a slice can be, as that
> seems the extra size check here. How about FF_MIN_BUFFER_SIZE ?
> Then the growth would be FFMAX(FF_MIN_BUFFER_SIZE, buf - orig_buf) ?
Here's a patch for that, and moving the warn
Hi,
2014-08-12 2:34 GMT+02:00 Michael Niedermayer :
>> +if (pkt_size <= buf - orig_buf) {
>
> this isnt sufficient, there could be 1 byte space left, then the
> reallocate wouldnt run and encode_slice() would run into the extra
> padding and fail
Yeah, you're right. I have no idea
On Mon, Aug 11, 2014 at 10:06:09PM +, Christophe Gisquet wrote:
> The buffer allocation may be incorrect (e.g. with an alpha plane),
> and currently causes the buffer to be set to NULL by init_put_bits,
> later on causing crashing.
>
> So, detect that situation, and if detected, reallocate the
10 matches
Mail list logo
