Re: [FFmpeg-devel] [PATCH 3/3] h264: Run VLC init under pthread_once

2015-10-07 Thread Hendrik Leppkes
On Wed, Oct 7, 2015 at 6:10 PM, Derek Buitenhuis wrote: > On 10/7/2015 4:57 PM, wm4 wrote: >> A static variable in a header file? This doesn't look right. You should >> define it in h264.c instead. > > [17:03] <+wm4> Daemon404: what exactly is the point of declaring the > init_once in the .h file

Re: [FFmpeg-devel] [PATCH 3/3] h264: Run VLC init under pthread_once

2015-10-07 Thread Derek Buitenhuis
On 10/7/2015 5:05 PM, Matt Oliver wrote: > Couldnt all the above if/includes be simplified by just using a single > include libavutil/thread.h (which has all the above checks in it. So, I included "thread.h", which is from avcodec, and it failed. I think it's pretty non-obvious I need the thread.h

Re: [FFmpeg-devel] [PATCH 3/3] h264: Run VLC init under pthread_once

2015-10-07 Thread Derek Buitenhuis
On 10/7/2015 4:57 PM, wm4 wrote: > A static variable in a header file? This doesn't look right. You should > define it in h264.c instead. [17:03] <+wm4> Daemon404: what exactly is the point of declaring the init_once in the .h file? [17:03] <@Daemon404> i didnt know the right place to put it [17:

Re: [FFmpeg-devel] [PATCH 3/3] h264: Run VLC init under pthread_once

2015-10-07 Thread Matt Oliver
On 8 October 2015 at 02:39, Derek Buitenhuis wrote: > This makes the h.264 decoder threadsafe to initialize. > > Signed-off-by: Derek Buitenhuis > --- > libavcodec/h264.c | 7 ++- > libavcodec/h264.h | 10 ++ > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/libav

Re: [FFmpeg-devel] [PATCH 3/3] h264: Run VLC init under pthread_once

2015-10-07 Thread wm4
On Wed, 7 Oct 2015 11:39:47 -0400 Derek Buitenhuis wrote: > This makes the h.264 decoder threadsafe to initialize. > > Signed-off-by: Derek Buitenhuis > --- > libavcodec/h264.c | 7 ++- > libavcodec/h264.h | 10 ++ > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --gi

Re: [FFmpeg-devel] [PATCH 3/3] h264: Run VLC init under pthread_once

2015-10-07 Thread Derek Buitenhuis
On 10/7/2015 4:39 PM, Derek Buitenhuis wrote: > +static pthread_once_t ff_h264_vlc_init = PTHREAD_ONCE_INIT; I've added av_unused here locally. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel