Re: [FFmpeg-devel] [PATCH 3/3] TTML encoder and muxer

2020-12-07 Thread Andreas Rheinhardt
Jan Ekström: > On Mon, Dec 7, 2020 at 4:03 PM Andreas Rheinhardt > wrote: >>> >>> You are not copying the terminating NUL; and you also don't account for >>> it in the above check. Is this intended? >>> >> >> The srt encoder does it like you, the ass encoder is careful only to >> output a NUL term

Re: [FFmpeg-devel] [PATCH 3/3] TTML encoder and muxer

2020-12-07 Thread Jan Ekström
On Mon, Dec 7, 2020 at 4:03 PM Andreas Rheinhardt wrote: > > > > You are not copying the terminating NUL; and you also don't account for > > it in the above check. Is this intended? > > > > The srt encoder does it like you, the ass encoder is careful only to > output a NUL terminated string (with

Re: [FFmpeg-devel] [PATCH 3/3] TTML encoder and muxer

2020-12-07 Thread Jan Ekström
On Mon, Dec 7, 2020 at 3:56 PM Andreas Rheinhardt wrote: > > Jan Ekström: > > From: Jan Ekström > > > > Enables encoding of other subtitle formats into TTML and writing > > them out as such documents. > > > > Signed-off-by: Jan Ekström > > --- > > Changelog | 1 + > > doc/g

Re: [FFmpeg-devel] [PATCH 3/3] TTML encoder and muxer

2020-12-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Jan Ekström: >> From: Jan Ekström >> >> Enables encoding of other subtitle formats into TTML and writing >> them out as such documents. >> >> Signed-off-by: Jan Ekström >> --- >> Changelog | 1 + >> doc/general_contents.texi | 1 + >> libavcodec/Makefi

Re: [FFmpeg-devel] [PATCH 3/3] TTML encoder and muxer

2020-12-07 Thread Andreas Rheinhardt
Jan Ekström: > From: Jan Ekström > > Enables encoding of other subtitle formats into TTML and writing > them out as such documents. > > Signed-off-by: Jan Ekström > --- > Changelog | 1 + > doc/general_contents.texi | 1 + > libavcodec/Makefile| 1 + > libavcode

Re: [FFmpeg-devel] [PATCH 3/3] TTML encoder and muxer

2020-12-04 Thread Paul B Mahol
AWESOME!! On Fri, Dec 4, 2020 at 3:55 PM Jan Ekström wrote: > From: Jan Ekström > > Enables encoding of other subtitle formats into TTML and writing > them out as such documents. > > Signed-off-by: Jan Ekström > --- > Changelog | 1 + > doc/general_contents.texi |