Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-07-06 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Le lauantaina 6. heinäkuuta 2024, 19.20.33 EEST Andreas Rheinhardt a écrit : >> Rémi Denis-Courmont: >>> Le lauantaina 6. heinäkuuta 2024, 18.23.00 EEST Andreas Rheinhardt a écrit > : > static void dct_unquantize_h263_inter_c(MpegEncContext *s, > >

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-07-06 Thread Rémi Denis-Courmont
Le lauantaina 6. heinäkuuta 2024, 19.20.33 EEST Andreas Rheinhardt a écrit : > Rémi Denis-Courmont: > > Le lauantaina 6. heinäkuuta 2024, 18.23.00 EEST Andreas Rheinhardt a écrit : > >>> static void dct_unquantize_h263_inter_c(MpegEncContext *s, > >>> > >>>in

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-07-06 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Le lauantaina 6. heinäkuuta 2024, 18.23.00 EEST Andreas Rheinhardt a écrit : >>> static void dct_unquantize_h263_inter_c(MpegEncContext *s, >>> >>>int16_t *block, int n, int qscale) >>> >>> { >>> >>> -int i, level, qmul, qadd; >>>

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-07-06 Thread Rémi Denis-Courmont
Le lauantaina 6. heinäkuuta 2024, 18.23.00 EEST Andreas Rheinhardt a écrit : > > static void dct_unquantize_h263_inter_c(MpegEncContext *s, > > > >int16_t *block, int n, int qscale) > > > > { > > > > -int i, level, qmul, qadd; > > +int qmul = qscal

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-07-06 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > --- > configure | 4 ++-- > libavcodec/mpegvideo.c | 40 +--- > 2 files changed, 11 insertions(+), 33 deletions(-) > > diff --git a/configure b/configure > index fed4c44cd1..42b9a72d5a 100755 > --- a/configure > +++ b/config

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-14 Thread Rémi Denis-Courmont
Le perjantaina 14. kesäkuuta 2024, 18.41.48 EEST James Almer a écrit : > On 6/14/2024 12:11 PM, Rémi Denis-Courmont wrote: > > Le perjantaina 14. kesäkuuta 2024, 17.45.50 EEST Rémi Denis-Courmont a écrit : > >> And x86 only has MMX. > > > > And the x86 code uses inline assembler. That's not viabl

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-14 Thread James Almer
On 6/14/2024 12:11 PM, Rémi Denis-Courmont wrote: Le perjantaina 14. kesäkuuta 2024, 17.45.50 EEST Rémi Denis-Courmont a écrit : And x86 only has MMX. And the x86 code uses inline assembler. That's not viable on any ISA with sane conventions such as Arm or RISC-V. The compiler will reject our

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-14 Thread Rémi Denis-Courmont
Le perjantaina 14. kesäkuuta 2024, 17.45.50 EEST Rémi Denis-Courmont a écrit : > And x86 only has MMX. And the x86 code uses inline assembler. That's not viable on any ISA with sane conventions such as Arm or RISC-V. The compiler will reject our vector clobbers, unless the Vector extension is in

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-14 Thread Rémi Denis-Courmont
Le 14 juin 2024 17:33:16 GMT+03:00, James Almer a écrit : >On 6/12/2024 1:47 AM, Rémi Denis-Courmont wrote: >> --- >> configure | 4 ++-- >> libavcodec/mpegvideo.c | 46 +++--- >> 2 files changed, 14 insertions(+), 36 deletions(-) >> >> diff

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-14 Thread James Almer
On 6/12/2024 1:47 AM, Rémi Denis-Courmont wrote: --- configure | 4 ++-- libavcodec/mpegvideo.c | 46 +++--- 2 files changed, 14 insertions(+), 36 deletions(-) diff --git a/configure b/configure index 6baa9b0646..eb9d1b1f5d 100755 --- a/confi

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-10 Thread Michael Niedermayer
On Mon, Jun 10, 2024 at 03:14:14PM +0300, Rémi Denis-Courmont wrote: > > > Le 10 juin 2024 14:41:31 GMT+03:00, Michael Niedermayer > a écrit : > >On Sun, Jun 09, 2024 at 07:23:45PM +0300, Rémi Denis-Courmont wrote: > >> --- > >> libavcodec/mpegvideo.c | 44 ++---

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-10 Thread Rémi Denis-Courmont
Le 10 juin 2024 14:41:31 GMT+03:00, Michael Niedermayer a écrit : >On Sun, Jun 09, 2024 at 07:23:45PM +0300, Rémi Denis-Courmont wrote: >> --- >> libavcodec/mpegvideo.c | 44 ++ >> 1 file changed, 10 insertions(+), 34 deletions(-) >> >> diff --git a/lib

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-10 Thread Michael Niedermayer
On Sun, Jun 09, 2024 at 07:23:45PM +0300, Rémi Denis-Courmont wrote: > --- > libavcodec/mpegvideo.c | 44 ++ > 1 file changed, 10 insertions(+), 34 deletions(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index 7af823b8bd..9be0fecc8d

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-09 Thread Rémi Denis-Courmont
Le sunnuntaina 9. kesäkuuta 2024, 19.13.54 EEST Andreas Rheinhardt a écrit : > Rémi Denis-Courmont: > > --- > > > > libavcodec/mpegvideo.c | 30 +- > > 1 file changed, 5 insertions(+), 25 deletions(-) > > > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-09 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > --- > libavcodec/mpegvideo.c | 30 +- > 1 file changed, 5 insertions(+), 25 deletions(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index 7af823b8bd..fa25d14970 100644 > --- a/libavcodec/mpegvideo.c > +++ b/libavcodec/mpeg