Re: [FFmpeg-devel] [PATCH 2/3] lavc: add standalone cached bitstream reader

2022-07-05 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-07-03 15:16:39) > Anton Khirnov: > > + > > +#include "mathops.h" > > What exactly is mathops.h for? get_bits.h uses it for NEG_USR32 and > NEG_SSR32, but you are not using it here. sign_extend()? > > +/** > > + * Skip bits to a byte boundary. > > + */ > > +static

Re: [FFmpeg-devel] [PATCH 2/3] lavc: add standalone cached bitstream reader

2022-07-03 Thread Andreas Rheinhardt
Anton Khirnov: > From: Alexandra Hájková > > The cached bitstream reader was originally written by Alexandra Hájková > for Libav, with significant input from Kostya Shishkov and Luca Barbato. > It was then committed to FFmpeg in ca079b09549, by merging it with the > implementation of the current