Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

2017-06-05 Thread Nicolas George
Le sextidi 16 prairial, an CCXXV, Ronald S. Bultje a écrit : > This reminds me of g_return_val_if_fail in glib, and in some situations > it's quite sensible and helpful. I think so too. But g_return_val_if_fail() has a flaw: it prints a warning and returns, at least with default builds of the lib

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

2017-06-04 Thread Ronald S. Bultje
Hi, On Sun, Jun 4, 2017 at 6:32 AM, Nicolas George wrote: > Le quintidi 15 prairial, an CCXXV, James Almer a écrit : > > On 6/3/2017 9:25 PM, Michael Niedermayer wrote: > > I see EINVAL more fit as an error for example if src or dst are NULL, > > something that would actually be an invalid argum

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

2017-06-04 Thread Nicolas George
Le quintidi 15 prairial, an CCXXV, James Almer a écrit : > On 6/3/2017 9:25 PM, Michael Niedermayer wrote: > I see EINVAL more fit as an error for example if src or dst are NULL, > something that would actually be an invalid argument. > We don't currently check that, for that matter. Maybe we shoul

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

2017-06-03 Thread James Almer
On 6/3/2017 9:55 PM, Michael Niedermayer wrote: > On Sat, Jun 03, 2017 at 09:47:32PM -0300, James Almer wrote: >> On 6/3/2017 9:25 PM, Michael Niedermayer wrote: >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/utils.c | 7 +++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --g

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

2017-06-03 Thread Michael Niedermayer
On Sat, Jun 03, 2017 at 09:47:32PM -0300, James Almer wrote: > On 6/3/2017 9:25 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/utils.c | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > > i

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

2017-06-03 Thread James Almer
On 6/3/2017 9:25 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/utils.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index cde5849a41..feee7556ac 100644 > --- a/libavcodec/utils.c > +++ b/libavco