Re: [FFmpeg-devel] [PATCH 2/2] lavfi/avf_concat: check input timestamp.

2020-08-30 Thread Paul B Mahol
On 8/23/20, Nicolas George wrote: > Michael Niedermayer (12020-08-23): >> > +if (buf->pts == AV_NOPTS_VALUE) { >> > +av_log(ctx, AV_LOG_ERROR, "Frame without timestamp on input >> > %d\n", in_no); >> > +return AVERROR(EINVAL); >> > +} >> >> what if the timestamp is "AV_NOPT

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/avf_concat: check input timestamp.

2020-08-23 Thread Nicolas George
Michael Niedermayer (12020-08-23): > > +if (buf->pts == AV_NOPTS_VALUE) { > > +av_log(ctx, AV_LOG_ERROR, "Frame without timestamp on input %d\n", > > in_no); > > +return AVERROR(EINVAL); > > +} > > what if the timestamp is "AV_NOPTS_VALUE + 1" ? > would that work or overfl

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/avf_concat: check input timestamp.

2020-08-23 Thread Michael Niedermayer
On Sun, Aug 09, 2020 at 12:56:53PM +0200, Nicolas George wrote: > If an input has an undefined timestamp, the computation > for silence at stitches can overflow. > > Partial fix for trac ticket #8843. > > Signed-off-by: Nicolas George > --- > libavfilter/avf_concat.c | 4 > 1 file changed,

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/avf_concat: check input timestamp.

2020-08-22 Thread Nicolas George
Nicolas George (12020-08-09): > If an input has an undefined timestamp, the computation > for silence at stitches can overflow. > > Partial fix for trac ticket #8843. > > Signed-off-by: Nicolas George > --- > libavfilter/avf_concat.c | 4 > 1 file changed, 4 insertions(+) Ping? Will apply