Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-14 Thread Michael Niedermayer
On Sun, Jul 13, 2025 at 07:09:13PM +0200, Marton Balint wrote: > > > On Fri, 11 Jul 2025, Michael Niedermayer wrote: > > > On Fri, Jul 11, 2025 at 10:29:30AM +0200, Nicolas George wrote: > > > Michael Niedermayer (HE12025-07-11): > > > > ok, chanegd it to AVERROR_INVALIDDATA > > > > > > Thanks.

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-13 Thread Marton Balint
On Fri, 11 Jul 2025, Michael Niedermayer wrote: On Fri, Jul 11, 2025 at 10:29:30AM +0200, Nicolas George wrote: Michael Niedermayer (HE12025-07-11): ok, chanegd it to AVERROR_INVALIDDATA Thanks. Yes but this also affects releases, and adding a field to AVFormatContext is an issue for re

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-11 Thread Michael Niedermayer
On Fri, Jul 11, 2025 at 10:29:30AM +0200, Nicolas George wrote: > Michael Niedermayer (HE12025-07-11): > > ok, chanegd it to AVERROR_INVALIDDATA > > Thanks. > > > Yes > > but this also affects releases, and adding a field to AVFormatContext > > is an issue for releases as it changes ABI > > > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-11 Thread Nicolas George
Michael Niedermayer (HE12025-07-11): > ok, chanegd it to AVERROR_INVALIDDATA Thanks. > Yes > but this also affects releases, and adding a field to AVFormatContext > is an issue for releases as it changes ABI > > So the concat patch would go into old release branches and the > AVFormatContext one

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-10 Thread Michael Niedermayer
Hi Nicolas On Wed, Jul 09, 2025 at 02:04:03PM +0200, Nicolas George wrote: > Michael Niedermayer (HE12025-07-07): > > a file called self_ref.ffconcat, containing: > > > > ffconcat version 1.0 > > file self_ref.ffconcat > > Oh, that. Thanks for explaining. I am not sure it is our responsibility >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-09 Thread Nicolas George
Michael Niedermayer (HE12025-07-07): > a file called self_ref.ffconcat, containing: > > ffconcat version 1.0 > file self_ref.ffconcat Oh, that. Thanks for explaining. I am not sure it is our responsibility to protect from this, there are many instance of similar pitfalls, for example a shell wrap

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-07 Thread Michael Niedermayer
On Mon, Jul 07, 2025 at 05:09:34PM +0200, Nicolas George wrote: > Michael Niedermayer (HE12025-07-07): > > not overflowing the stack from unlimited recursion > > What unlimited recursion? a file called self_ref.ffconcat, containing: ffconcat version 1.0 file self_ref.ffconcat [...] -- Michael

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-07 Thread Nicolas George
Michael Niedermayer (HE12025-07-07): > not overflowing the stack from unlimited recursion What unlimited recursion? Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-07 Thread Michael Niedermayer
On Mon, Jul 07, 2025 at 01:05:35PM +0200, Nicolas George wrote: > Michael Niedermayer (HE12025-07-07): > > This variant is easy backportable but is concatdec specific > > > > Fixes: self_ref.ffconcat > > Reported-by: Yuhao Jiang > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/con

Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth

2025-07-07 Thread Nicolas George
Michael Niedermayer (HE12025-07-07): > This variant is easy backportable but is concatdec specific > > Fixes: self_ref.ffconcat > Reported-by: Yuhao Jiang > Signed-off-by: Michael Niedermayer > --- > libavformat/concatdec.c | 11 +++ > 1 file changed, 11 insertions(+) What use case is