Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-30 Thread Paul B Mahol
On 3/29/19, Nick Renieris wrote: > Στις Παρ, 29 Μαρ 2019 στις 11:05 π.μ., ο/η Paul B Mahol > έγραψε: >> You should also check max number of available pages. >> And issue warning if user requested more than available and than provide >> some >> page. > > Yeah, I _would_ have done that, but the ima

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-29 Thread Nick Renieris
Στις Παρ, 29 Μαρ 2019 στις 11:05 π.μ., ο/η Paul B Mahol έγραψε: > You should also check max number of available pages. > And issue warning if user requested more than available and than provide some > page. Yeah, I _would_ have done that, but the images I've seen don't actually contain the max nu

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-29 Thread Paul B Mahol
On 3/29/19, Nick Renieris wrote: > Huh? No I fixed that, it's AV_OPT_TYPE_INT now. > See the second email in this list (first was the initial patch, then > the corrected patch). > You should also check max number of available pages. And issue warning if user requested more than available and than

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-28 Thread Nick Renieris
Huh? No I fixed that, it's AV_OPT_TYPE_INT now. See the second email in this list (first was the initial patch, then the corrected patch). Στις Παρ, 29 Μαρ 2019 στις 12:51 π.μ., ο/η Paul B Mahol έγραψε: > > On 3/28/19, Nick Renieris wrote: > > Ok, here's a multipage tif with 3 pages, the two fir

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-28 Thread Paul B Mahol
On 3/28/19, Nick Renieris wrote: > Ok, here's a multipage tif with 3 pages, the two first are blue and > the last one red: > https://0x0.st/zKdB.tif > Patch contains UINT16 opt and as is can not be applied. Please fix that. > Στις Πέμ, 28 Μαρ 2019 στις 4:35 μ.μ., ο/η Paul B Mahol > έγραψε: >> >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-28 Thread Nick Renieris
Ok, here's a multipage tif with 3 pages, the two first are blue and the last one red: https://0x0.st/zKdB.tif Στις Πέμ, 28 Μαρ 2019 στις 4:35 μ.μ., ο/η Paul B Mahol έγραψε: > > On 3/28/19, Nick Renieris wrote: > > When I made the patch I did ask you on IRC whether I should upload > > something a

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-28 Thread Paul B Mahol
On 3/28/19, Nick Renieris wrote: > When I made the patch I did ask you on IRC whether I should upload > something and got no answer. > Please upload it, somewhere like https://0x0.st/ > Στις Πέμ, 28 Μαρ 2019 στις 2:58 μ.μ., ο/η Nick Renieris > έγραψε: >> >> I haven't, is there a specific place

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-28 Thread Nick Renieris
When I made the patch I did ask you on IRC whether I should upload something and got no answer. Στις Πέμ, 28 Μαρ 2019 στις 2:58 μ.μ., ο/η Nick Renieris έγραψε: > > I haven't, is there a specific place that it's preferred I upload it to? > > Στις Πέμ, 28 Μαρ 2019 στις 1:12 μ.μ., ο/η Paul B Mahol >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-28 Thread Nick Renieris
I haven't, is there a specific place that it's preferred I upload it to? Στις Πέμ, 28 Μαρ 2019 στις 1:12 μ.μ., ο/η Paul B Mahol έγραψε: > > On 3/28/19, Nick Renieris wrote: > > Any news on this? Is there something I should do? > > Have you uploaded small tiff so this patch can be tested? > > > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-28 Thread Paul B Mahol
On 3/28/19, Nick Renieris wrote: > Any news on this? Is there something I should do? Have you uploaded small tiff so this patch can be tested? > > Στις Σάβ, 23 Μαρ 2019 στις 2:54 μ.μ., ο/η Carl Eugen Hoyos > έγραψε: >> >> 2019-03-23 13:34 GMT+01:00, Paul B Mahol : >> > On 3/23/19, Carl Eugen Ho

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-28 Thread Nick Renieris
Any news on this? Is there something I should do? Στις Σάβ, 23 Μαρ 2019 στις 2:54 μ.μ., ο/η Carl Eugen Hoyos έγραψε: > > 2019-03-23 13:34 GMT+01:00, Paul B Mahol : > > On 3/23/19, Carl Eugen Hoyos wrote: > >> 2019-03-23 9:11 GMT+01:00, Paul B Mahol : > >>> On 3/22/19, Carl Eugen Hoyos wrote: >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-23 Thread Carl Eugen Hoyos
2019-03-23 13:34 GMT+01:00, Paul B Mahol : > On 3/23/19, Carl Eugen Hoyos wrote: >> 2019-03-23 9:11 GMT+01:00, Paul B Mahol : >>> On 3/22/19, Carl Eugen Hoyos wrote: 2019-03-22 15:50 GMT+01:00, velocit...@gmail.com : > From: Nick Renieris > > Option "-page N" (page index N start

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-23 Thread Paul B Mahol
On 3/23/19, Carl Eugen Hoyos wrote: > 2019-03-23 9:11 GMT+01:00, Paul B Mahol : >> On 3/22/19, Carl Eugen Hoyos wrote: >>> 2019-03-22 15:50 GMT+01:00, velocit...@gmail.com : From: Nick Renieris Option "-page N" (page index N starts from 1) can now be used to specify which TIF

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-23 Thread Carl Eugen Hoyos
2019-03-23 9:11 GMT+01:00, Paul B Mahol : > On 3/22/19, Carl Eugen Hoyos wrote: >> 2019-03-22 15:50 GMT+01:00, velocit...@gmail.com : >>> From: Nick Renieris >>> >>> Option "-page N" (page index N starts from 1) can now >>> be used to specify which TIFF page/subfile to decode. >> >> What is the c

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-23 Thread Paul B Mahol
On 3/22/19, Carl Eugen Hoyos wrote: > 2019-03-22 15:50 GMT+01:00, velocit...@gmail.com : >> From: Nick Renieris >> >> Option "-page N" (page index N starts from 1) can now >> be used to specify which TIFF page/subfile to decode. > > What is the current behaviour? > Shouldn't the decoder output al

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-22 Thread Nick Renieris
Στις Παρ, 22 Μαρ 2019 στις 6:35 μ.μ., ο/η Moritz Barsnick έγραψε: > I was about to write "could you please also update the documentation", > but just realized that the tiff encoder isn't documented. :-P Hahah. I can solve that in a later patch :) Στις Σάβ, 23 Μαρ 2019 στις 12:13 π.μ., ο/η Carl E

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

2019-03-22 Thread Carl Eugen Hoyos
2019-03-22 15:50 GMT+01:00, velocit...@gmail.com : > From: Nick Renieris > > Option "-page N" (page index N starts from 1) can now > be used to specify which TIFF page/subfile to decode. What is the current behaviour? Shouldn't the decoder output all pages as for a video file? Carl Eugen ___