Re: [FFmpeg-devel] [PATCH 1/7] avcodec/vc1: Check for excessive resolution

2019-08-19 Thread Tomas Härdin
mån 2019-08-19 klockan 11:19 +0200 skrev Jean-Baptiste Kempf: > > On Mon, Aug 19, 2019, at 11:02, Tomas Härdin wrote: > > mån 2019-08-19 klockan 08:17 +0200 skrev Jean-Baptiste Kempf: > > > You need to explain why. A "NAK" is not enough. > > > > > > 16k pixels x 16k is a large size already for vc

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/vc1: Check for excessive resolution

2019-08-19 Thread Jean-Baptiste Kempf
On Mon, Aug 19, 2019, at 11:02, Tomas Härdin wrote: > mån 2019-08-19 klockan 08:17 +0200 skrev Jean-Baptiste Kempf: > > You need to explain why. A "NAK" is not enough. > > > > 16k pixels x 16k is a large size already for vc1. > > Why not fix the calculation? 16K is a thing, and larger resolutio

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/vc1: Check for excessive resolution

2019-08-19 Thread Tomas Härdin
mån 2019-08-19 klockan 08:17 +0200 skrev Jean-Baptiste Kempf: > You need to explain why. A "NAK" is not enough. > > 16k pixels x 16k is a large size already for vc1. Why not fix the calculation? 16K is a thing, and larger resolutions are inevitable.. /Tomas _

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/vc1: Check for excessive resolution

2019-08-19 Thread Paul B Mahol
On Mon, Aug 19, 2019 at 9:46 AM Jean-Baptiste Kempf wrote: > > > On Mon, Aug 19, 2019, at 09:45, Paul B Mahol wrote: > > On Mon, Aug 19, 2019 at 8:17 AM Jean-Baptiste Kempf > wrote: > > > > > You need to explain why. A "NAK" is not enough. > > > > > > 16k pixels x 16k is a large size already for

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/vc1: Check for excessive resolution

2019-08-19 Thread Jean-Baptiste Kempf
On Mon, Aug 19, 2019, at 09:45, Paul B Mahol wrote: > On Mon, Aug 19, 2019 at 8:17 AM Jean-Baptiste Kempf wrote: > > > You need to explain why. A "NAK" is not enough. > > > > 16k pixels x 16k is a large size already for vc1. > > > > And for any other codecs Sure. In VLC we limit to 8k x 8

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/vc1: Check for excessive resolution

2019-08-19 Thread Paul B Mahol
On Mon, Aug 19, 2019 at 8:17 AM Jean-Baptiste Kempf wrote: > You need to explain why. A "NAK" is not enough. > > 16k pixels x 16k is a large size already for vc1. > And for any other codecs > > On Sun, Aug 18, 2019, at 12:45, Paul B Mahol wrote: > > NAK > > > > On Thu, Aug 15, 2019 at 11:5

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/vc1: Check for excessive resolution

2019-08-18 Thread Jean-Baptiste Kempf
You need to explain why. A "NAK" is not enough. 16k pixels x 16k is a large size already for vc1. On Sun, Aug 18, 2019, at 12:45, Paul B Mahol wrote: > NAK > > On Thu, Aug 15, 2019 at 11:51 PM Michael Niedermayer > wrote: > > > Fixes: overflow in aspect ratio calculation > > Fixes: signed inte

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/vc1: Check for excessive resolution

2019-08-18 Thread Paul B Mahol
NAK On Thu, Aug 15, 2019 at 11:51 PM Michael Niedermayer wrote: > Fixes: overflow in aspect ratio calculation > Fixes: signed integer overflow: 393215 * 14594 cannot be represented in > type 'int' > Fixes: > 15728/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3IMAGE_fuzzer-566158889320448