Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-04 Thread Henrik Gramner
On Mon, Aug 3, 2015 at 8:12 PM, Hendrik Leppkes wrote: > On Mon, Aug 3, 2015 at 5:26 PM, James Almer wrote: >> On 03/08/15 9:50 AM, Hendrik Leppkes wrote: >>> Otherwise, I tested the patch with msvc 2013 32-bit, and fate passed fine. >>> If there is something else I should specifically test which

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread James Almer
On 03/08/15 3:25 PM, Hendrik Leppkes wrote: > On Mon, Aug 3, 2015 at 8:21 PM, James Almer wrote: >> On 03/08/15 3:12 PM, Hendrik Leppkes wrote: >>> Since I wasn't sure in which direction of packed/planar the problem >>> usually happened, I tried 8ch s32 -> 8ch s32p, 8ch s32 -> 2ch s32p, >>> 8ch s3

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 8:21 PM, James Almer wrote: > On 03/08/15 3:12 PM, Hendrik Leppkes wrote: >> Since I wasn't sure in which direction of packed/planar the problem >> usually happened, I tried 8ch s32 -> 8ch s32p, 8ch s32 -> 2ch s32p, >> 8ch s32p -> 8ch s32 and 8ch s32p -> 2ch s32, and all wor

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread James Almer
On 03/08/15 3:12 PM, Hendrik Leppkes wrote: > Since I wasn't sure in which direction of packed/planar the problem > usually happened, I tried 8ch s32 -> 8ch s32p, 8ch s32 -> 2ch s32p, > 8ch s32p -> 8ch s32 and 8ch s32p -> 2ch s32, and all work fine. > > - Hendrik If those tests were done with lib

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 5:26 PM, James Almer wrote: > On 03/08/15 9:50 AM, Hendrik Leppkes wrote: >> On Mon, Aug 3, 2015 at 10:31 AM, Henrik Gramner wrote: >>> On Mon, Aug 3, 2015 at 2:18 AM, Ronald S. Bultje wrote: So, I think the code changes themselves look mostly healthy. Is there a

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread James Almer
On 03/08/15 9:50 AM, Hendrik Leppkes wrote: > On Mon, Aug 3, 2015 at 10:31 AM, Henrik Gramner wrote: >> On Mon, Aug 3, 2015 at 2:18 AM, Ronald S. Bultje wrote: >>> So, I think the code changes themselves look mostly healthy. Is there a >>> behavioural difference before/after this patch? (Like: we

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Dewangan, Hitesh Kumar
Hi all, Can you please remove me from this group. Thanks, Hitesh On Aug 3, 2015 2:14 AM, "Henrik Gramner" wrote: > Change ALLOC_STACK to always align the stack before allocating stack space > for > consistency. Previously alignment would occur either before or after > allocating > stack space d

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Ronald S. Bultje
Hi, On Mon, Aug 3, 2015 at 8:50 AM, Hendrik Leppkes wrote: > On Mon, Aug 3, 2015 at 10:31 AM, Henrik Gramner > wrote: > > On Mon, Aug 3, 2015 at 2:18 AM, Ronald S. Bultje > wrote: > >> So, I think the code changes themselves look mostly healthy. Is there a > >> behavioural difference before/af

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 10:31 AM, Henrik Gramner wrote: > On Mon, Aug 3, 2015 at 2:18 AM, Ronald S. Bultje wrote: >> So, I think the code changes themselves look mostly healthy. Is there a >> behavioural difference before/after this patch? (Like: were there bugs in >> the original code, or does th

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Henrik Gramner
On Mon, Aug 3, 2015 at 2:18 AM, Ronald S. Bultje wrote: > So, I think the code changes themselves look mostly healthy. Is there a > behavioural difference before/after this patch? (Like: were there bugs in > the original code, or does this change behaviour of previous code in a > significant way?)

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-02 Thread Ronald S. Bultje
Hi, On Sun, Aug 2, 2015 at 4:40 PM, Henrik Gramner wrote: > Change ALLOC_STACK to always align the stack before allocating stack space > for > consistency. Previously alignment would occur either before or after > allocating > stack space depending on whether manual alignment was required or not

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-02 Thread Ronald S. Bultje
Hi, On Sun, Aug 2, 2015 at 7:56 PM, James Almer wrote: > On 02/08/15 5:40 PM, Henrik Gramner wrote: > > Change ALLOC_STACK to always align the stack before allocating stack > space for > > consistency. Previously alignment would occur either before or after > allocating > > stack space depending

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-02 Thread James Almer
On 02/08/15 5:40 PM, Henrik Gramner wrote: > Change ALLOC_STACK to always align the stack before allocating stack space for > consistency. Previously alignment would occur either before or after > allocating > stack space depending on whether manual alignment was required or not. > --- > libavcod