Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Ronald S. Bultje
Hi, On Sun, May 7, 2017 at 7:50 AM, Nicolas George wrote: > L'octidi 18 floréal, an CCXXV, Ronald S. Bultje a écrit : > > My understanding from what Nicolas said is that the goal is to have > > higher-level code (utils.c-level, e.g. the callers of filter() or > > encode_frame() or get_buffer() i

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Hendrik Leppkes
On Sun, May 7, 2017 at 1:47 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, May 7, 2017 at 7:34 AM, Marton Balint wrote: > >> >> On Sat, 6 May 2017, Nicolas George wrote: >> >> Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >>> As far as I know. No new features can go to release bran

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Hendrik Leppkes
On Sun, May 7, 2017 at 1:34 PM, Marton Balint wrote: > > On Sat, 6 May 2017, Nicolas George wrote: > >> Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >>> >>> As far as I know. No new features can go to release branch. >>> Or maybe I'm wrong. >> >> >> As I said, if this is the only issue

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Nicolas George
L'octidi 18 floréal, an CCXXV, Marton Balint a écrit : > I suggest to return 1 if an actual alignment (with deep copy) happened. Actually, as Muhammad just pointed and as I noticed a few minutes ago, we can not use the same function from lavfi and lavc, due to the get_buffer issue. I propose the

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Muhammad Faiz
On Sun, May 7, 2017 at 6:34 PM, Marton Balint wrote: > > On Sat, 6 May 2017, Nicolas George wrote: > >> Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >>> >>> As far as I know. No new features can go to release branch. >>> Or maybe I'm wrong. >> >> >> As I said, if this is the only issue

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Nicolas George
L'octidi 18 floréal, an CCXXV, Marton Balint a écrit : > As the av_frame_realign API is useful on its own without any framework, I > suggest we implement that. > > Once the implementation is complete we can backport it to 3.3 with the > avpriv prefix and without bumping version numbers. > > In th

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Nicolas George
L'octidi 18 floréal, an CCXXV, Ronald S. Bultje a écrit : > My understanding from what Nicolas said is that the goal is to have > higher-level code (utils.c-level, e.g. the callers of filter() or > encode_frame() or get_buffer() inside decode_frame()) call this for every > input frame going back to

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Ronald S. Bultje
Hi, On Sun, May 7, 2017 at 7:34 AM, Marton Balint wrote: > > On Sat, 6 May 2017, Nicolas George wrote: > > Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >> >>> As far as I know. No new features can go to release branch. >>> Or maybe I'm wrong. >>> >> >> As I said, if this is the only

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Marton Balint
On Sat, 6 May 2017, Nicolas George wrote: TODO Actual implementation. Signed-off-by: Nicolas George --- libavutil/frame.h | 9 + 1 file changed, 9 insertions(+) Here is a proposal for actually fixing the alignment problems that are all over the place in the current code base. Note

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-07 Thread Marton Balint
On Sat, 6 May 2017, Nicolas George wrote: Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : As far as I know. No new features can go to release branch. Or maybe I'm wrong. As I said, if this is the only issue, then it is not: just copy-paste av_frame_realign() at the two places where

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-06 Thread Nicolas George
Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : > As far as I know. No new features can go to release branch. > Or maybe I'm wrong. As I said, if this is the only issue, then it is not: just copy-paste av_frame_realign() at the two places where it will be needed and make it static. But r

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-06 Thread Hendrik Leppkes
On Sat, May 6, 2017 at 5:40 PM, Muhammad Faiz wrote: > On Sat, May 6, 2017 at 9:39 PM, Nicolas George wrote: >> Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >>> Whatever the result here (accepted or rejected), we still need a fix >>> without API change. Otherwise, it can't go to 3.3 b

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-06 Thread Muhammad Faiz
On Sat, May 6, 2017 at 9:39 PM, Nicolas George wrote: > Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : >> Whatever the result here (accepted or rejected), we still need a fix >> without API change. Otherwise, it can't go to 3.3 branch. > > There is no API change as is (except for the ext

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-06 Thread Nicolas George
Le septidi 17 floréal, an CCXXV, Muhammad Faiz a écrit : > Whatever the result here (accepted or rejected), we still need a fix > without API change. Otherwise, it can't go to 3.3 branch. There is no API change as is (except for the extra function in lavu, but that is only an add, and can be worke

Re: [FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

2017-05-06 Thread Muhammad Faiz
On Sat, May 6, 2017 at 4:20 PM, Nicolas George wrote: > TODO Actual implementation. > > Signed-off-by: Nicolas George > --- > libavutil/frame.h | 9 + > 1 file changed, 9 insertions(+) > > > Here is a proposal for actually fixing the alignment problems that are all > over the place in th