Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: av_realloc -> av_realloc_array()

2020-06-01 Thread lance . lmwang
On Sat, May 30, 2020 at 11:14:03AM -0300, James Almer wrote: > On 5/30/2020 10:55 AM, lance.lmw...@gmail.com wrote: > > On Sat, May 30, 2020 at 03:32:18PM +0200, Nicolas George wrote: > >> lance.lmw...@gmail.com (12020-05-30): > >>> From: Limin Wang > >>> > >>> Signed-off-by: Limin Wang > >>> ---

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: av_realloc -> av_realloc_array()

2020-05-30 Thread lance . lmwang
On Sat, May 30, 2020 at 04:03:33PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-05-30): > > I think it's cosmetic changes, so I didn't change the alignment for the > > first version. > > If it's OK, I'll update with format changes also. > > Please, try to see the moon, not the fin

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: av_realloc -> av_realloc_array()

2020-05-30 Thread James Almer
On 5/30/2020 10:55 AM, lance.lmw...@gmail.com wrote: > On Sat, May 30, 2020 at 03:32:18PM +0200, Nicolas George wrote: >> lance.lmw...@gmail.com (12020-05-30): >>> From: Limin Wang >>> >>> Signed-off-by: Limin Wang >>> --- >>> libavutil/dict.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 del

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: av_realloc -> av_realloc_array()

2020-05-30 Thread Nicolas George
lance.lmw...@gmail.com (12020-05-30): > I think it's cosmetic changes, so I didn't change the alignment for the first > version. > If it's OK, I'll update with format changes also. Please, try to see the moon, not the finger. Why do you think we insist on cosmetic changes on separate patches? Be

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: av_realloc -> av_realloc_array()

2020-05-30 Thread lance . lmwang
On Sat, May 30, 2020 at 03:32:18PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-05-30): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavutil/dict.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavutil/dict.c b/liba

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: av_realloc -> av_realloc_array()

2020-05-30 Thread Nicolas George
lance.lmw...@gmail.com (12020-05-30): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/dict.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavutil/dict.c b/libavutil/dict.c > index 0ea7138..a1107b1 100644 > --- a/libavutil/dict.c > +++ b/liba