Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Marvin Scholz
On 8 Jul 2025, at 20:33, Nicolas George wrote: > Marvin Scholz (HE12025-07-08): >> That's already possible with `-tls_verify 0` > > Then the commit message inadequately explains what the patch does. > Please clarify. Sure, I will add a more verbose message. However note that verification was a

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Nicolas George
Marvin Scholz (HE12025-07-08): > Sure, I will add a more verbose message. Thanks. > How could that work though? Warn for every tls use > in ffmpeg unless the user explicitly specifies > -tls_verify 1 or -tls_verify 0? > I think a lot of people would complain about that? Warn each time verificati

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Nicolas George
Marvin Scholz (HE12025-07-08): > That's already possible with `-tls_verify 0` Then the commit message inadequately explains what the patch does. Please clarify. > (which is actually the default, arguably shouldn't be IMHO but > thats a different topic) A transition period where only a warning is

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Marvin Scholz
On 8 Jul 2025, at 20:21, Nicolas George wrote: > Marvin Scholz (HE12025-07-08): >> Can you clarify? That's already possible with `-tls_verify 0` (which is actually the default, arguably shouldn't be IMHO but thats a different topic) > > wget(1): > >--no-check-certificate >D

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Nicolas George
Marvin Scholz (HE12025-07-08): > Can you clarify? wget(1): --no-check-certificate Don't check the server certificate against the available certificate authorities. Also don't require the URL host name to match the common name presented by the certific

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Marvin Scholz
On 8 Jul 2025, at 20:16, Nicolas George wrote: > Marvin Scholz (HE12025-07-08): >> From: Daniel N Pettersson >> >> Co-Authored-By: Marvin Scholz >> --- >> libavformat/tls_openssl.c | 9 - >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/tls_openssl.c b

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Nicolas George
Marvin Scholz (HE12025-07-08): > From: Daniel N Pettersson > > Co-Authored-By: Marvin Scholz > --- > libavformat/tls_openssl.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index a0fa3285d5..7614caf089 1