Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-15 Thread Andreas Cadhalpun
On 16.12.2016 02:29, Rodger Combs wrote: >> On Dec 15, 2016, at 19:21, Andreas Cadhalpun >> wrote: >> On 15.12.2016 14:02, Ronald S. Bultje wrote: >>> - if for whatever reason some things cannot be done in generic code or by >>> changing the type (this should really cover most cases), and we wan

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-15 Thread Rodger Combs
> On Dec 15, 2016, at 19:21, Andreas Cadhalpun > wrote: > > On 15.12.2016 14:02, Ronald S. Bultje wrote: >> On Wed, Dec 14, 2016 at 7:11 PM, Andreas Cadhalpun < >> andreas.cadhal...@googlemail.com> wrote: >>> On 14.12.2016 02:46, Ronald S. Bultje wrote: Not wanting to discourage you, but I

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-15 Thread Andreas Cadhalpun
On 15.12.2016 14:02, Ronald S. Bultje wrote: > On Wed, Dec 14, 2016 at 7:11 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: >> On 14.12.2016 02:46, Ronald S. Bultje wrote: >>> Not wanting to discourage you, but I wonder if there's really a point to >>> this...? >> >> These patche

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-15 Thread Michael Niedermayer
On Thu, Dec 15, 2016 at 03:57:57PM -0500, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 15, 2016 at 9:28 AM, Michael Niedermayer > wrote: > > > On Thu, Dec 15, 2016 at 08:02:52AM -0500, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Wed, Dec 14, 2016 at 7:11 PM, Andreas Cadhalpun < > > > andre

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-15 Thread Ronald S. Bultje
Hi, On Thu, Dec 15, 2016 at 9:28 AM, Michael Niedermayer wrote: > On Thu, Dec 15, 2016 at 08:02:52AM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Dec 14, 2016 at 7:11 PM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > > > > On 14.12.2016 02:46, Ronald S. Bultje wr

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-15 Thread Michael Niedermayer
On Thu, Dec 15, 2016 at 08:02:52AM -0500, Ronald S. Bultje wrote: > Hi, > > On Wed, Dec 14, 2016 at 7:11 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > > > On 14.12.2016 02:46, Ronald S. Bultje wrote: > > > Not wanting to discourage you, but I wonder if there's really a poin

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-15 Thread Ronald S. Bultje
Hi, On Wed, Dec 14, 2016 at 7:11 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 14.12.2016 02:46, Ronald S. Bultje wrote: > > Not wanting to discourage you, but I wonder if there's really a point to > > this...? > > These patches are prerequisites for enforcing the validity

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-14 Thread Andreas Cadhalpun
On 14.12.2016 03:54, Michael Niedermayer wrote: > On Wed, Dec 14, 2016 at 01:57:54AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/4xm.c | 8 +++- >> 1 file changed, 7 insertions(+), 1 deletion(-) > > LGTM Pushed. Best regards, Andreas _

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-14 Thread Andreas Cadhalpun
On 14.12.2016 02:46, Ronald S. Bultje wrote: > Not wanting to discourage you, but I wonder if there's really a point to > this...? These patches are prerequisites for enforcing the validity of codec parameters [1]. > I don't see how the user experience changes. Users won't see ffmpeg claiming no

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-13 Thread Michael Niedermayer
On Wed, Dec 14, 2016 at 01:57:54AM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/4xm.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-13 Thread Ronald S. Bultje
Hi, On Tue, Dec 13, 2016 at 8:21 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 14.12.2016 02:01, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Dec 13, 2016 at 7:57 PM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > > >> Signed-off-by: Andreas Cadhal

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-13 Thread Andreas Cadhalpun
On 14.12.2016 02:01, Ronald S. Bultje wrote: > Hi, > > On Tue, Dec 13, 2016 at 7:57 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/4xm.c | 8 +++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --g

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-13 Thread Ronald S. Bultje
Hi, On Tue, Dec 13, 2016 at 7:57 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/4xm.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavformat/4xm.c b/libavformat/4xm.c > index 8a50778..2