Re: [FFmpeg-devel] [PATCH 1/2] Add NewTek NDI headers

2018-02-20 Thread Nicolas George
Maksym Veremeyenko (2018-02-20): > attached patch add a NewTek NDI headers to source tree. I am against this, and the second patch, based on principles: this is helping NewTek circumvent the GPL. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH 1/2] Add NewTek NDI headers

2018-02-20 Thread Ricardo Constantino
On 20 February 2018 at 16:32, Maksym Veremeyenko wrote: > Hi > > attached patch add a NewTek NDI headers to source tree. > > these headers is under MIT license. > > please apply. > Also, there's still no consideration that there's other compilers in Windows other than MSVC: +#ifdef _WIN32 +#def

Re: [FFmpeg-devel] [PATCH 1/2] Add NewTek NDI headers

2018-02-20 Thread wm4
On Tue, 20 Feb 2018 18:32:48 +0200 Maksym Veremeyenko wrote: > Hi > > attached patch add a NewTek NDI headers to source tree. > > these headers is under MIT license. > > please apply. > As it was concluded in the discussion about the AMD headers, we don't accept vendor headers in the main gi

Re: [FFmpeg-devel] [PATCH 1/2] Add NewTek NDI headers

2018-02-20 Thread Ricardo Constantino
On 20 February 2018 at 16:32, Maksym Veremeyenko wrote: > Hi > > attached patch add a NewTek NDI headers to source tree. > > these headers is under MIT license. > > please apply. > Why not make them available in a public git repository instead? FFmpeg is trying to remove these third-party header