Re: [FFmpeg-devel] [PATCH 08/21] avformat/matroskadec: Improve error messages

2019-04-08 Thread Andreas Rheinhardt via ffmpeg-devel
Steve Lhomme: >> On April 7, 2019 at 11:24 AM Andreas Rheinhardt via ffmpeg-devel >> wrote: >> >> >> Steve Lhomme: >>> On 3/27/2019 12:18 PM, Andreas Rheinhardt via ffmpeg-devel wrote: ebml_read_num had a number of flaws: 1. The check for read errors/EOF was totally wrong. E.g. an

Re: [FFmpeg-devel] [PATCH 08/21] avformat/matroskadec: Improve error messages

2019-04-07 Thread Steve Lhomme
> On April 7, 2019 at 11:24 AM Andreas Rheinhardt via ffmpeg-devel > wrote: > > > Steve Lhomme: > > On 3/27/2019 12:18 PM, Andreas Rheinhardt via ffmpeg-devel wrote: > >> ebml_read_num had a number of flaws: > >> > >> 1. The check for read errors/EOF was totally wrong. E.g. an EBML number > >>

Re: [FFmpeg-devel] [PATCH 08/21] avformat/matroskadec: Improve error messages

2019-04-07 Thread Andreas Rheinhardt via ffmpeg-devel
Steve Lhomme: > On 3/27/2019 12:18 PM, Andreas Rheinhardt via ffmpeg-devel wrote: >> ebml_read_num had a number of flaws: >> >> 1. The check for read errors/EOF was totally wrong. E.g. an EBML number >> beginning with the invalid 0x00 would be considered a read error, >> although it is just invalid

Re: [FFmpeg-devel] [PATCH 08/21] avformat/matroskadec: Improve error messages

2019-04-06 Thread Steve Lhomme
On 3/27/2019 12:18 PM, Andreas Rheinhardt via ffmpeg-devel wrote: ebml_read_num had a number of flaws: 1. The check for read errors/EOF was totally wrong. E.g. an EBML number beginning with the invalid 0x00 would be considered a read error, although it is just invalid data. 2. The check for read