Re: [FFmpeg-devel] [PATCH 07/12] cngenc: Add missing error check

2017-07-06 Thread Derek Buitenhuis
On 7/6/2017 10:07 PM, Rostislav Pehlivanov wrote: > Just remove setting and checking the return value altogether, > ff_lpc_calc_ref_coeffs returns the order which you give it and can't error > out. Would look good to me if you did that, so feel free to push once done. OK. - Derek

Re: [FFmpeg-devel] [PATCH 07/12] cngenc: Add missing error check

2017-07-06 Thread Rostislav Pehlivanov
On 6 July 2017 at 19:28, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/cngenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/cngenc.c b/libavcodec/cngenc.c > index 302c703f72..b7207fd5f6 100644 > --- a/libavcodec/cngenc.c > +++ b/libavcode